dotnet · dipeshmsft · Oct 4, 2024 · May 1, 2024
@@ -104,7 +104,6 @@ internal static void HandleWebResponse(WebResponse response)
         }
     }
 
-    [FriendAccessAllowed] // called by PF.Application.GetCookie()
     [SuppressMessage("Microsoft.Interoperability", "CA1404:CallGetLastErrorImmediatelyAfterPInvoke", 
         Justification="It's okay now. Be careful on change.")]
     internal static string GetCookie(Uri uri, bool throwIfNoCookie)
@@ -128,7 +127,6 @@ internal static string GetCookie(Uri uri, bool throwIfNoCookie)
         throw new Win32Exception(/*uses last error code*/);
     }
 
-    [FriendAccessAllowed] // called by PF.Application.SetCookie()
     internal static bool SetCookie(Uri uri, string cookieData)
     {
         return SetCookieUnsafe(uri, cookieData, null);

@@ -38,7 +38,6 @@
 
 namespace MS.Internal.AppModel
 {
-    [FriendAccessAllowed]
     internal class CustomCredentialPolicy : ICredentialPolicy
     {
         static CustomCredentialPolicy()

@@ -23,7 +23,6 @@
 using System.Windows;
 using System.Windows.Navigation;
 using System.Security;
-using MS.Internal.PresentationCore;
 
 namespace MS.Internal.AppModel
 {
@@ -46,7 +45,6 @@ internal class SiteOfOriginContainer : System.IO.Packaging.Package
 
         internal static Uri SiteOfOrigin
         {
-            [FriendAccessAllowed]
             get
             {
                 Uri siteOfOrigin = SiteOfOriginForClickOnceApp;

@@ -9,11 +9,8 @@
 
 using System.Security;
 
-using MS.Internal.PresentationCore;
-
 namespace MS.Internal.Automation
 {
-    [FriendAccessAllowed] // Built into Core, also used by Framework.
     internal class InteropAutomationProvider: IRawElementProviderFragmentRoot
     {
         #region Constructors

@@ -27,7 +27,6 @@
 using MS.Utility;
 using MS.Internal;
 using MS.Internal.FontFace;
-using MS.Internal.PresentationCore;
 using MS.Internal.Shaping;
 
 // Since we disable PreSharp warnings in this file, we first need to disable warnings about unknown message numbers and unknown pragmas.
@@ -39,7 +38,6 @@ namespace MS.Internal.FontCache
     /// FamilyCollection font cache element class is responsible for
     /// storing the mapping between a folder and font families in it
     /// </summary>
-    [FriendAccessAllowed]
     internal class FamilyCollection
     {
         //------------------------------------------------------

@@ -37,7 +37,6 @@ namespace MS.Internal.FontCache
     /// <summary>
     /// FontCacheFullException is raised when the cache limit is reached
     /// </summary>
-    [FriendAccessAllowed]
     internal class FontCacheFullException : ApplicationException
     {
         internal FontCacheFullException()
@@ -51,7 +50,6 @@ internal FontCacheFullException()
     /// 4 byte element type
     /// Everything else is element-specific
     /// </summary>
-    [FriendAccessAllowed]
     internal interface IFontCacheElement
     {
         /// <summary>
@@ -121,7 +119,6 @@ bool IsAppSpecific
     /// - fixed size hash table, 4 bytes per element
     /// - user data pool, active length is variable, maximum length is determined by the font cache file size
     /// </summary>
-    [FriendAccessAllowed]
     internal unsafe class ElementCacher
     {
         private const int numberOfBuckets = 512;

@@ -46,7 +46,6 @@ namespace MS.Internal.FontCache
     /// The purpose of the class is to protect the memory block from overruns.
     /// ArgumentOutOfRangeException is thrown when an overrun is detected.
     /// </summary>
-    [FriendAccessAllowed]
     internal struct CheckedPointer
     {
         internal unsafe CheckedPointer(void * pointer, int size)
@@ -214,7 +213,6 @@ internal bool ReadBool()
     /// <summary>
     /// HashFn is a port of predefined hash functions from LKRHash
     /// </summary>
-    [FriendAccessAllowed]
     internal static class HashFn
     {
         // Small prime number used as a multiplier in the supplied hash functions
@@ -283,7 +281,6 @@ internal static int HashString(string s, int hash)
     /// <summary>
     /// Utility functions for interaction with font cache service
     /// </summary>
-    [FriendAccessAllowed]
     internal static class Util
     {
         internal const int nullOffset = -1;
@@ -803,7 +800,6 @@ internal static Exception ConvertInPageException(FontSource fontSource, SEHExcep
     /// <summary>
     /// A class that wraps operations with Win32 memory sections and file mappings
     /// </summary>
-    [FriendAccessAllowed]
     internal class FileMapping : UnmanagedMemoryStream
     {
         ~FileMapping()

@@ -30,7 +30,6 @@
 
 namespace MS.Internal.FontCache
 {
-    [FriendAccessAllowed]
     internal sealed class FontFaceLayoutInfo
     {
         private FontTechnology _fontTechnology;

@@ -16,7 +16,6 @@
 
 namespace MS.Internal.FontCache
 {
-    [FriendAccessAllowed]
     internal class FontCacheConfig
     {
         private enum ProtocolType { Single, Dual, ALPC };

@@ -16,7 +16,6 @@
 using System.Windows;
 using MS.Internal;
 using SR=MS.Internal.PresentationCore.SR;
-using MS.Internal.PresentationCore;
 
 namespace System.Windows.Media.Converters
 {
@@ -29,7 +28,6 @@ namespace System.Windows.Media.Converters
     /// <summary>
     /// The base converter for IList of T to string conversion in XAML serialization
     /// </summary>    
-    [FriendAccessAllowed]   // all implementations are used by Framework at serialization    
     public abstract class BaseIListConverter : TypeConverter 
     { 
         /// <Summary>

@@ -36,7 +36,6 @@ namespace MS.Internal.IO.Packaging
     /// For now, we will only process one batch of requests at a time. We will most likely
     ///  want to spin multiple threads and do multiple batches at a time in the future
     /// </remarks>
-    [FriendAccessAllowed]
     internal class ByteRangeDownloader : IDisposable
     {
          //------------------------------------------------------

@@ -30,7 +30,6 @@ namespace MS.Internal.IO.Packaging
     ///  class and we won't be using even half of the dictionary functionalities.
     ///  If this class becomes a public class which is strongly discouraged, this class
     ///  needs to implement IDictionary.</remarks>
-    [FriendAccessAllowed]
     internal static class PreloadedPackages 
     {
         //------------------------------------------------------

@@ -27,7 +27,6 @@ namespace System.Windows.Ink
     /// and updates the visual state as necessary.
     /// </summary>
     ///
-    [FriendAccessAllowed] // Built into Core, also used by Framework.
     internal class Renderer
     {
         #region StrokeVisual

@@ -14,7 +14,6 @@
 
 using SR=MS.Internal.PresentationCore.SR;
 using MS.Internal;
-using MS.Internal.PresentationCore;
 
 namespace MS.Internal.Ink
 {
@@ -203,7 +202,6 @@ internal static void CalcGeometryAndBoundsWithTransform(StrokeNodeIterator itera
         /// strokenodes is very expensive later when MIL renders it, so this method has been optimized
         /// to only add strokenodes when either pressure changes, or the angle of the stroke changes.
         /// </summary>
-        [FriendAccessAllowed]
         internal static void CalcGeometryAndBounds(StrokeNodeIterator iterator,
                                                    DrawingAttributes drawingAttributes,
 #if DEBUG_RENDERING_FEEDBACK

@@ -6,11 +6,8 @@
 using System.Windows;
 using System.Windows.Media;
 
-using MS.Internal.PresentationCore;
-
 namespace MS.Internal.KnownBoxes
 {
-    [FriendAccessAllowed] // Built into Core, also used by Framework.
     internal static class FillRuleBoxes
     {
         internal static object EvenOddBox = FillRule.EvenOdd;
@@ -29,7 +26,6 @@ internal static object Box(FillRule value)
         }
     }
 
-    [FriendAccessAllowed] // Built into Core, also used by Framework.
     internal static class VisibilityBoxes
     {
         internal static object VisibleBox = Visibility.Visible;

@@ -13,11 +13,9 @@
 
 using System.Windows;               // DependencyObject
 using System.Windows.Threading;     // DispatcherOperationCallback
-using MS.Internal.PresentationCore; // [FriendAccessAllowed]
 
 namespace MS.Internal
 {
-    [FriendAccessAllowed] // Built into Core, also used by Framework.
     internal class LoadedOrUnloadedOperation
     {
         internal LoadedOrUnloadedOperation(

@@ -12,21 +12,18 @@
 using System;
 using System.Windows;
 using System.Windows.Media;
-using MS.Internal.PresentationCore;
 
 namespace MS.Internal.Media
 {
     /// <summary>
     /// Provide access to text options of element in syntax of TextOptions.xxx = yyy;
     /// Actual data is stored in the owner.
     /// </summary>
-    [FriendAccessAllowed]   // used by Framework
     internal static class TextOptionsInternal
     {
         #region Dependency Properties
 
         /// <summary> Text hinting property </summary>
-        [FriendAccessAllowed]   // used by Framework
         internal static readonly DependencyProperty TextHintingModeProperty = 
                 DependencyProperty.RegisterAttached(
                         "TextHintingMode",
@@ -40,15 +37,13 @@ internal static class TextOptionsInternal
 
         #region Attached Properties Setters
 
-        [FriendAccessAllowed]   // used by Framework
         public static void SetTextHintingMode(DependencyObject element, TextHintingMode value)
         {
             ArgumentNullException.ThrowIfNull(element);
 
             element.SetValue(TextHintingModeProperty, value);
         }
 
-        [FriendAccessAllowed]   // used by Framework
         public static TextHintingMode GetTextHintingMode(DependencyObject element)
         {
             ArgumentNullException.ThrowIfNull(element);

@@ -12,7 +12,7 @@
 using System.Globalization; // CultureInfo 
 
 #if PRESENTATION_CORE
-using MS.Internal.PresentationCore;     // FriendAccessAllowed
+using MS.Internal.PresentationCore;
 #elif PRESENTATIONFRAMEWORK
 using MS.Internal.PresentationFramework; 
 #endif 
@@ -188,9 +188,6 @@ internal enum SerializationFloatType : byte
         /// <remarks>
         /// This is called ONLY from the Parser and is not a general public method.  
         /// </remarks>
-#if !PBTCOMPILER        
-        [FriendAccessAllowed] // Built into Core, also used by Framework.
-#endif        
         internal static bool SerializePoint3D(BinaryWriter writer, string stringValues)
         {
 #if PBTCOMPILER            
@@ -223,9 +220,6 @@ internal static bool SerializePoint3D(BinaryWriter writer, string stringValues)
         /// <remarks>
         /// This is called ONLY from the Parser and is not a general public method.  
         /// </remarks>
-#if !PBTCOMPILER        
-        [FriendAccessAllowed] // Built into Core, also used by Framework.
-#endif        
         internal static bool SerializeVector3D(BinaryWriter writer, string stringValues)
         {
 #if PBTCOMPILER            
@@ -258,9 +252,6 @@ internal static bool SerializeVector3D(BinaryWriter writer, string stringValues)
         /// <remarks>
         /// This is called ONLY from the Parser and is not a general public method.  
         /// </remarks>
-#if !PBTCOMPILER        
-        [FriendAccessAllowed] // Built into Core, also used by Framework.
-#endif        
         internal static bool SerializePoint(BinaryWriter writer, string stringValue)
         {
 #if PBTCOMPILER            

@@ -20,7 +20,6 @@
 using System.Windows.Media;
 using System.Windows.Media.Media3D;
 
-using MS.Internal.PresentationCore;
 using MS.Internal.Media3D;
 using SR = MS.Internal.PresentationCore.SR;
 
@@ -1227,7 +1226,6 @@ public override GeneralTransform Inverse
         /// </summary>        
         internal override Transform AffineTransform
         {
-            [FriendAccessAllowed] // Built into Core, also used by Framework.
             get
             {
                 return null;

@@ -23,7 +23,6 @@
 using System.Windows.Media.Composition;
 using System.Windows.Markup;
 using System.Windows.Media.Media3D;
-using MS.Internal.PresentationCore;
 
 namespace MS.Internal.Media3D
 {
@@ -89,7 +88,6 @@ public override GeneralTransform3D Inverse
         /// </summary>
         internal override Transform3D AffineTransform
         {
-            [FriendAccessAllowed] // Built into Core, also used by Framework.
             get
             {
                 return null;

@@ -18,7 +18,6 @@
 using System.Windows.Media;
 using System.Windows.Media.TextFormatting;
 using System.Runtime.InteropServices;
-using MS.Internal.PresentationCore;
 
 using SR = MS.Internal.PresentationCore.SR;
 
@@ -31,7 +30,6 @@ namespace MS.Internal.TextFormatting
     /// access to the underlying dangerous handle to the unmanaged resource whose
     /// lifetime is bound to the the underlying LS context.
     /// </summary>
-    [FriendAccessAllowed]   // used by Framework
     internal sealed class TextPenaltyModule : IDisposable
     {
         private SecurityCriticalDataForSet<IntPtr>  _ploPenaltyModule;  // Pointer to LS penalty module