Unseal the PasswordBox to allow it to be extended with, for example, a clear button.#8005
Open
pomianowski wants to merge 2 commits intodotnet:mainfrom
Open
Unseal the PasswordBox to allow it to be extended with, for example, a clear button.#8005pomianowski wants to merge 2 commits intodotnet:mainfrom
PasswordBox to allow it to be extended with, for example, a clear button.#8005pomianowski wants to merge 2 commits intodotnet:mainfrom
Conversation
ghost
assigned
ghost
requested a review
from 
pomianowski
changed the title
PasswordBox to to allow it to be extended with, for example, a clear button.PasswordBox to allow it to be extended with, for example, a clear button.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The change is intended to open up the PasswordBox API and allow the creation of derived classes. I believe that an openly accessible control should not be sealed. In this situation, we either have to rewrite the entire
PasswordBoxor use other tricks instead of conveniently creating a derived class.Customer Impact
Until now, it is unlikely that anyone has created derived classes, so we are opening up opportunities rather than taking them away.
Regression
Not applicable
Testing
PR build
Risk
Changing the behavior of
PasswordBoxby, for example, addingOnPasswordChanged(e)can be risky because of how users use the control so far.Microsoft Reviewers: Open in CodeFlow