Fixing exception thrown in GenerateTemporaryTargetAssembly when project name has GB characters in it #8151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned
ghost
requested a review
from 
Contributor
Author
|
Sample name for project, that can repro the exception. |
rainersigwald
approved these changes
Aug 29, 2023
Contributor
|
Please note that using path/url when loading a XML document uses the URL as a base URL for resolving and reading DTDs referenced from the XML file. You lose that by switching to a stream, potentially changing the meaning of the XML content. That said, I do not expect any csproj files to be using DTD so we are probably OK here. |
Kuldeep-MS
approved these changes
Oct 29, 2023
Contributor
Kuldeep-MS
left a comment
Kuldeep-MS
left a comment
There was a problem hiding this comment.
Changes Look good to me
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
Exception thrown in GenerateTemporaryTargetAssembly when project name has GB characters in it
Main PR
None
Description
Bugfix for GB chars, exception thrown when using Load(CurrentProject), when project name has GB characters in it.
Using a filestream instead of using string path to avoid the need to properly compose Uri (which is another way of fixing - but more complicated).
Customer Impact
Users will face build error, when building a project which has GB Characters in the project name.
Regression
None
Testing
Local
Risk
Low
Microsoft Reviewers: Open in CodeFlow