Skip to content

Fixing exception thrown in GenerateTemporaryTargetAssembly when project name has GB characters in it #8151

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 29, 2023
Merged

Fixing exception thrown in GenerateTemporaryTargetAssembly when project name has GB characters in it #8151

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions ...c/PresentationBuildTasks/Microsoft/Build/Tasks/Windows/GenerateTemporaryTargetAssembly.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,12 @@ private bool ExecuteLegacyGenerateTemporaryTargetAssembly()
XmlDocument xmlProjectDoc = null;

xmlProjectDoc = new XmlDocument( );
xmlProjectDoc.Load(CurrentProject);

//Bugfix for GB chars, exception thrown when using Load(CurrentProject), when project name has GB characters in it.
//Using a filestream instead of using string path to avoid the need to properly compose Uri (which is another way of fixing - but more complicated).
using(FileStream fs = File.OpenRead(CurrentProject))
{
xmlProjectDoc.Load(fs);
}
//
// remove all the WinFX specific item lists
// ApplicationDefinition, Page, MarkupResource and Resource
Expand Down Expand Up @@ -247,8 +251,12 @@ private bool ExecuteGenerateTemporaryTargetAssemblyWithPackageReferenceSupport()
XmlDocument xmlProjectDoc = null;

xmlProjectDoc = new XmlDocument( );
xmlProjectDoc.Load(CurrentProject);

//Bugfix for GB chars, exception thrown when using Load(CurrentProject), when project name has GB characters in it.
//Using a filestream instead of using string path to avoid the need to properly compose Uri (which is another way of fixing - but more complicated).
using(FileStream fs = File.OpenRead(CurrentProject))
{
xmlProjectDoc.Load(fs);
}
// remove all the WinFX specific item lists
// ApplicationDefinition, Page, MarkupResource and Resource
RemoveItemsByName(xmlProjectDoc, APPDEFNAME);
Expand Down