Skip to content

Applying Win11 Styles to TabControl, Frame, Page#8579

Merged
harshit7962 merged 1 commit intodotnet:feature/win11theming/stagingfrom
harshit7962:controlBatch2
Jan 5, 2024
Merged

Applying Win11 Styles to TabControl, Frame, Page#8579
harshit7962 merged 1 commit intodotnet:feature/win11theming/stagingfrom
harshit7962:controlBatch2

Conversation

@harshit7962
Copy link
Member

@harshit7962 harshit7962 commented Dec 21, 2023 •
edited by ghost
Loading

Description

Adding Win11 Styles to the following controls:

  1. TabControl
  2. Page
  3. Frame

Testing

Build Pass.
Verified the visual appearance changes of controls in a sample application.

Microsoft Reviewers: Open in CodeFlow

@harshit7962 harshit7962 requested a review from a team as a code owner December 21, 2023 11:19
@ghost ghost assigned harshit7962 Dec 21, 2023
@ghost ghost added the PR metadata: Label to tag PRs, to facilitate with triage label Dec 21, 2023
@ghost ghost requested review from dipeshmsft and singhashish-wpf December 21, 2023 11:19
anjaligupta-dev
anjaligupta-dev suggested changes Dec 21, 2023
View reviewed changes
Copy link

@anjaligupta-dev anjaligupta-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ghost ghost added the 📭 waiting-author-feedback To request more information from author. label Dec 21, 2023
@ghost ghost removed the 📭 waiting-author-feedback To request more information from author. label Dec 22, 2023
@tbibre
Copy link

tbibre commented Dec 22, 2023

Hi,
I haven't checked this commit in details, but last time I checked, WPF UI TabControl style was not respecting TabStripPlacement : lepoco/wpfui#214

@pchaurasia14
Copy link
Contributor

pchaurasia14 commented Dec 22, 2023

@tbibre - Sure thing. We'll check it out

@lindexi lindexi mentioned this pull request Dec 25, 2023
Open
@harshit7962
Copy link
Member Author

harshit7962 commented Dec 29, 2023

@tbibre - We have raised the issue here. Will keep updating leads there. Thanks for bringing this to our notice.

@harshit7962 harshit7962 merged commit 8c438a3 into dotnet:feature/win11theming/staging Jan 5, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Feb 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@dipeshmsft dipeshmsft dipeshmsft approved these changes

@singhashish-wpf singhashish-wpf Awaiting requested review from singhashish-wpf

+2 more reviewers

@lindexi lindexi lindexi left review comments

@anjaligupta-dev anjaligupta-dev anjaligupta-dev approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@harshit7962 harshit7962

Labels

PR metadata: Label to tag PRs, to facilitate with triage Win 11 Theming

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@harshit7962 @tbibre @pchaurasia14 @lindexi @anjaligupta-dev @dipeshmsft