Switch to System.Formats.Nrbf #9465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-policy-service
bot
added
the
PR
adamsitnik
commented
Jul 25, 2024
src/Microsoft.DotNet.Wpf/src/PresentationCore/System/Windows/BinaryFormat/NullableAttributes.cs
Show resolved
Hide resolved
adamsitnik
commented
Jul 25, 2024
...crosoft.DotNet.Wpf/src/PresentationCore/System/Windows/Nrbf/SerializationRecordExtensions.cs
Show resolved
Hide resolved
adamsitnik
commented
Jul 25, 2024
src/Microsoft.DotNet.Wpf/src/PresentationFramework/MS/Internal/DataStreams.cs
Show resolved
Hide resolved
adamsitnik
commented
Jul 25, 2024
src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/PresentationCore.Tests.csproj
Outdated
Show resolved
Hide resolved
# Conflicts: # eng/Versions.props # src/Microsoft.DotNet.Wpf/tests/UnitTests/PresentationCore.Tests/PresentationCore.Tests.csproj
Member
Author
|
@rchauhan18 I've solved the merge conflict and thanks to @ThomasGoulet73 we now know that I've not broken anything and all tests are passing |
# Conflicts: # eng/Versions.props
rchauhan18
previously approved these changes
Jul 30, 2024
Contributor
rchauhan18
left a comment
rchauhan18
left a comment
There was a problem hiding this comment.
@adamsitnik Thanks for your contribution!
# Conflicts: # eng/Versions.props
rchauhan18
approved these changes
Jul 30, 2024
pchaurasia14
added a commit
to pchaurasia14/wpf
that referenced
this pull request
Aug 1, 2024
* install the System.Formats.Nrbf package * switch to the new API * remove unused methods * remove everything related to parsing NRBF payloads and records that don't support writing * try to fix and update the tests * remove more unused code
ericstj
pushed a commit
that referenced
this pull request
Aug 1, 2024
* install the System.Formats.Nrbf package * switch to the new API * remove unused methods * remove everything related to parsing NRBF payloads and records that don't support writing * try to fix and update the tests * remove more unused code Fixed conflict in Versions.props, and added missing entry to Version.Details.xml
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It mimics what I did in dotnet/winforms#11745 for WinForms: switch to
System.Formats.Nrbffor parsing Binary Formatter payloads (and have only one such parser across all the products).I've left the existing records as they support writing and there are no plans for
System.Formats.Nrbfto ever support it.Microsoft Reviewers: Open in CodeFlow