Adding SystemFormats.Nrbf fixes #9506
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* install the System.Formats.Nrbf package * switch to the new API * remove unused methods * remove everything related to parsing NRBF payloads and records that don't support writing * try to fix and update the tests * remove more unused code
WPF was depending on the package version of System.Runtime.Serialization.Formatters but never shipping it. �Instead WPF should depend on the built-in assembly version. To do that we need to update the SDK version since WPF's vcxprojs don't enable the nuget package targeting pack dotnet#9490
dotnet-policy-service
bot
added
the
PR
ericstj
reviewed
Aug 1, 2024
| <PackageReference Include="xunit.stafact" Version="$(XUnitStaFactPackageVersion)" /> | ||
| <PackageReference Include="FluentAssertions" Version="$(FluentAssertionsVersion)" /> | ||
| <PackageReference Include="System.Collections.Concurrent" Version="4.3.0" /> | ||
| <PackageReference Include="System.Runtime.Serialization.Formatters" Version="9.0.0-preview.7.24359.11 " /> |
Member
There was a problem hiding this comment.
This looks wrong. We shouldn't have hardcoded versions in the projects.
Contributor
Author
There was a problem hiding this comment.
I tried to keep the changes to minimum and pick only the changes that were introduced in the 2 original PRs.
Contributor
Author
|
Closing in favor of #9507 . |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull in changes from #9465 and #9492 to support nrbf code for Preview7
Customer Impact
Customers using .NET 9 Preview 7 would continue to take in implicit dependency on BinaryFormatter nuget package.
Regression
No.
Testing
Local testing and compat-lab applications
Risk
Medium.
Microsoft Reviewers: Open in CodeFlow
cc - @adamsitnik , @ericstj