Remove CheckedPointer struct and replace its use with Span<T> instances#9531
Open
h3xds1nz wants to merge 2 commits intodotnet:mainfrom
Open
Remove CheckedPointer struct and replace its use with Span<T> instances#9531h3xds1nz wants to merge 2 commits intodotnet:mainfrom
h3xds1nz wants to merge 2 commits intodotnet:mainfrom
Conversation
32ee796 to
c5ee887
Compare
Member
Author
|
Resolved merge conflicts 10 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes
CheckedPointerwhich was used in quite some places back in early WPF implementations inNetFXbut now the only thing using it isTrueTypeFontDriverand replaces it withReadOnlySpan<T>.Probechecks are the same as implemented byReadOnlySpan<T>when slicing.Marshal.Copywith simple.ToArray()call fromReadOnlySpan<T>inComputeFontSubset.Sliceand non-Try methods fromBinaryPrimitivesto be sure the exception behavior stays the same.SetFacemethodCustomer Impact
Smaller code-size of PresentationCore, improved performance in this particular scenario.
For developers it introduces more familiar types in internal classes than custom implementations for a simple thing.
Regression
No.
Testing
Tested base font file parsing and class (
TrueTypeFontDriver) functionality afterCheckedPointerremoval.Risk
Low.
Microsoft Reviewers: Open in CodeFlow