Remove internal permissions types and most of SecurityHelper

[ojhad]

Opened an internal PR which should be merged first in order to avoid build errors.

Part if issue #241

• Removed dependence on System.Security.Permission.dll for internal types that extend from System.Security.Permission.dll types
• Deleted internal permission types
• Deleted most of SecurityHelper

[vatsan-madhavan]

General observation: MS.Internal.WindowsBase.SecurityHelper in its entirely can be removed. It consists of DemandXXX() type helpers, and one CheckXX() method.

I realize that this suggestion doesn't directly overlap with the core purpose of this PR (which is to remove types that directly inherit from S.S.Permission types), and that you are planning on putting out a separate PR that excises code containing asserts/demands etc.

That said, some overlap in purpose is unavoidable , I think. For e..g., not following the logical thread to remove RightsManagementPermission etc. now would just lead to the inadvertent retention of dead code. In the next round of analysis, for e.g. some of these types would appear as if they have relationship to S.S.Permission types... and possibly lead us to ignore them. So better to remove them when we are looking closely at these types.

The rest of SecurityHelper (i.e., the parts that are not directly affected by this PR) itself can be handled now or later - that's upto you. I personally think it might be easier to delete the whole thing and adjust the codebase once, rather than doing it piecemeal.

[rladuca]

The rest of SecurityHelper (i.e., the parts that are not directly affected by this PR) itself can be handled now or later - that's upto you. I personally think it might be easier to delete the whole thing and adjust the codebase once, rather than doing it piecemeal.

In my eyes it makes sense, time permitting, to remove as much as possible of the CAS specific code as early as possible. We're digging around right now, let's do this before other items take precedence.

[ojhad]

The rest of SecurityHelper (i.e., the parts that are not directly affected by this PR) itself can be handled now or later - that's upto you. I personally think it might be easier to delete the whole thing and adjust the codebase once, rather than doing it piecemeal.

Removed most of the SecurityHelper methods. Left a couple methods which have some non-cas related logic and left ExtractAppDomainPermissionSetMinusSiteOfOrigin which is more difficult to remove (however it does not keep a dependency on System.Security.Permissions.dll).

Opened an internal PR as well which should be merged first in order to avoid errors.

[vatsan-madhavan]

Removed most of the SecurityHelper methods. Left a couple methods which have some non-cas related logic and left ExtractAppDomainPermissionSetMinusSiteOfOrigin which is more difficult to remove (however it does not keep a dependency on System.Security.Permissions.dll).

Pretty straightforward to fix this. You can cherry pick my change from 49f8134

[vatsan-madhavan]

Consider cherry-picking 49f8134 into this before merging.

[dotMorten]

Note: This PR also fixes #722

[vatsan-madhavan]

30cbe44 has what you need to remove System.Xaml.XamlObjectWriterSettings.AccessLevel