Optimize FigureLength struct conversion to string, reduce allocations#9888
Open
h3xds1nz wants to merge 5 commits intodotnet:mainfrom
Open
Optimize FigureLength struct conversion to string, reduce allocations#9888h3xds1nz wants to merge 5 commits intodotnet:mainfrom
h3xds1nz wants to merge 5 commits intodotnet:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Optimizes conversion of
FigureLengthtostring. Simplifies Can* methods, adds some documentation.Simple ToString conversion
Customer Impact
Improved performance, decreased allocations.
Regression
No.
Testing
Local build, conversion tests.
Risk
Low; do note that #9887 should be taken first imho.
Microsoft Reviewers: Open in CodeFlow