Use ThreadStatic fields over LocalDataStoreSlot for improved performance#9959
Open
h3xds1nz wants to merge 13 commits intodotnet:mainfrom
Open
Use ThreadStatic fields over LocalDataStoreSlot for improved performance#9959h3xds1nz wants to merge 13 commits intodotnet:mainfrom
h3xds1nz wants to merge 13 commits intodotnet:mainfrom
Conversation
e45283a to
5f642cb
Compare
Member
Author
|
Rebased and resolved merge conflicts. |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #9959 +/- ##
===================================================
- Coverage 10.95887% 10.90597% -0.05290%
===================================================
Files 3310 3310
Lines 664667 664297 -370
Branches 74667 74664 -3
===================================================
- Hits 72840 72448 -392
- Misses 590685 590717 +32
+ Partials 1142 1132 -10
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Replaces
LocalDataStoreSlotwith[ThreadStatic]fields for improved performance and increased type safety.LocalDataStoreSlotis about500 nsand184 B, that will forever live.Thread.GetDatais about 40% more expensive.LocalDataStoreSlotthese days (though it usesThreadLocal<object?>under the hood since .NET Core 3.0 afaik so the performance is not THAT bad, whileNetFXstill goes with the original impl).In the other commits, I've just cleaned up some CAS remnants (
Critical/Unsecuremethods/properties) fromComponentDispatcher, that just unnecessarily complicate the code these days. Since the formatting was different style on each, I've unified that.10 property retrievals before/after (already initialized)
Customer Impact
Improved performance, increased code base quality and type safety for developers.
Regression
No.
Testing
Local build, sample app run and testing with all the modified types.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow