Remove SafeSecurityHelperAvalon, move functionality to PresentationSource#9978
Open
h3xds1nz wants to merge 3 commits intodotnet:mainfrom
Open
Remove SafeSecurityHelperAvalon, move functionality to PresentationSource#9978h3xds1nz wants to merge 3 commits intodotnet:mainfrom
h3xds1nz wants to merge 3 commits intodotnet:mainfrom
Conversation
dotnet-policy-service
bot
requested review from
dipeshmsft and
singhashish-wpf
dotnet-policy-service
bot
added
PR
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
One
SecurityHelperfile down, two to go.This one was a partial class from
SafeSecurityHelper, containing a simple wrapper forPresentationSource.FromVisualwith aboolcheck. It was compiled unconditionally both intoPresentationFrameworkandPresentationCore, though the functionality is not needed in both assemblies.Also removed some obsolete CAS remarks in
PresentationSourceand used pattern matching in some places to simplify code.Customer Impact
Decreased size of assemblies, cleaner code base for developers.
Regression
No.
Testing
Local build.
Risk
Low.
Microsoft Reviewers: Open in CodeFlow