Use Spans and ReadOnlyCollection.Empty in TextBlock/Line, reduce allocs#9993
Open
h3xds1nz wants to merge 14 commits intodotnet:mainfrom
Open
Use Spans and ReadOnlyCollection.Empty in TextBlock/Line, reduce allocs#9993h3xds1nz wants to merge 14 commits intodotnet:mainfrom
h3xds1nz wants to merge 14 commits intodotnet:mainfrom
Conversation
…new List<Rect>(0))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Bringing some optimizations to
TextBlockcontrol and related components (Line;ComplexLine).Initializemethod in TextBlock'sctorhas been removed.GetLineIndexFromDcpandClearComplexContenthave been removed (EnsureComplexContenthandles the detach if its needed)new ReadOnlyCollection<T>(new List<T>(0))numerous times, we swap to the non-allocating, generic singleton variant ofReadOnlyCollection<T>.Empty, removing all possible overhead.ArrayListforInlineObjectsinComplexContentwithList<InlineObject>.ComplexLine-double adjustedXOffset(method doesn't modify state either)AlignContent-Vector contentOffset(method doesn't modify state either)GetRangeBoundsinLineinstead of using aList<Rect>now uses pre-allocatedRect[]that's wrapped inReadOnlySpan<Rect>to its callers on return.List<TextSegment>(1)and usingInsert(that's a great combination), we useTextSegment[].GetTightBoundingGeometryFromTextPositionswith more thoughtful impl.new
ReadOnlyCollection<T>(new List<T>(0))vsEmptyGetRangeBoundscall old vs. new and the loop itself; without combining geometriesGetTightBoundingGeometryFromTextPositions inner loop (1 rect)
Customer Impact
Increased performance, decreased allocations.
Regression
No.
Testing
Local build, sample apps run.
Risk
Should be low, the changes are pretty much mechanical.
Microsoft Reviewers: Open in CodeFlow