Invoke all event handlers; fix User JSON#33
Merged
johnkors merged 1 commit intodotnetbots:mainfrom Mar 3, 2026
Merged
Conversation
Update AppHomeOpenedEvents and MemberJoinedEvents to iterate and execute all registered handlers rather than using only the first. Add null/empty checks for handler collections, per-handler logging and error handling, and return HTTP 200 directly (AppHomeOpenedEvents) instead of calling next. MemberJoinedEvents signature was converted to a primary-constructor style and logging usage was unified. Also update Interactive.User JSON mapping from "user_id" to "id" to match the expected payload.
johnkors
approved these changes
Mar 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://docs.slack.dev/reference/interaction-payloads/block_actions-payload/
I never got User.User_id to work, according to docs User.id is correct
Update AppHomeOpenedEvents and MemberJoinedEvents to iterate and execute all registered handlers rather than using only the first. Add null/empty checks for handler collections, per-handler logging and error handling, and return HTTP 200 directly (AppHomeOpenedEvents) instead of calling next. MemberJoinedEvents signature was converted to a primary-constructor style and logging usage was unified. Also update Interactive.User JSON mapping from "user_id" to "id" to match the expected payload.