feat(PdfReader): add ShowPrint parameter #7191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's GuideUpdates the PdfReaders sample component to demonstrate new configurable PdfReader toolbar options (ShowPrint, ShowDownload, ShowTwoPagesOneView) and wires them to the PdfReader control with sensible defaults and improved layout/styling. Sequence diagram for toggling PdfReader toolbar options at runtimesequenceDiagram
actor User
participant PdfReaders
participant PdfReader
User->>PdfReaders: Toggle Switch bound_to__showDownload
PdfReaders->>PdfReaders: Update _showDownload
PdfReaders->>PdfReader: Re_render with ShowDownload = _showDownload
User->>PdfReaders: Toggle Switch bound_to__showPrint
PdfReaders->>PdfReaders: Update _showPrint
PdfReaders->>PdfReader: Re_render with ShowPrint = _showPrint
User->>PdfReaders: Toggle Switch bound_to__showTwoPagesOneView
PdfReaders->>PdfReaders: Update _showTwoPagesOneView
PdfReaders->>PdfReader: Re_render with ShowTwoPagesOneView = _showTwoPagesOneView
Updated class diagram for PdfReaders sample and PdfReader parametersclassDiagram
class PdfReaders {
-PdfReader PdfReader
-bool _showTwoPagesOneView
-bool _showPrint
-bool _showDownload
-string _url
+Task OnDownloadAsync()
}
class PdfReader {
+string Url
+bool ShowTwoPagesOneView
+bool ShowDownload
+bool ShowPrint
+string ViewHeight
+Func Task OnDownloadAsync
}
PdfReaders --> PdfReader : uses
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
# Conflicts: # src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj # src/BootstrapBlazor.Server/Components/Samples/PdfReaders.razor # src/BootstrapBlazor.Server/Components/Samples/PdfReaders.razor.cs
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey there - I've reviewed your changes - here's some feedback:
- The new labels "ShowDownload", "ShowPrint", and "ShowTwoPagesOneView" are hard-coded; consider binding them through
Localizer[...]like the rest of the sample text so they participate in localization. - The inline style
style="--bb-input-group-label-width: 176px;"on the<section>could be moved into a CSS class to keep styling concerns out of the markup and make future adjustments easier.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The new labels "ShowDownload", "ShowPrint", and "ShowTwoPagesOneView" are hard-coded; consider binding them through `Localizer[...]` like the rest of the sample text so they participate in localization.
- The inline style `style="--bb-input-group-label-width: 176px;"` on the `<section>` could be moved into a CSS class to keep styling concerns out of the markup and make future adjustments easier.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7191 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32583 32583
Branches 4515 4515
=========================================
Hits 32583 32583
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds a ShowPrint parameter to the PdfReader component, allowing users to control the visibility of the print button. The demo page has been refactored to showcase individual parameter controls with switches.
- Refactored the demo to use individual boolean flags instead of a single options object
- Added ShowPrint, ShowDownload, and ShowTwoPagesOneView switches for user control
- Upgraded BootstrapBlazor.PdfReader package from 10.0.1-beta05 to 10.0.1-beta07
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/BootstrapBlazor.Server/Components/Samples/PdfReaders.razor.cs | Added dependency injections and download handler; replaced options object with individual boolean flags |
| src/BootstrapBlazor.Server/Components/Samples/PdfReaders.razor | Updated UI to show individual parameter switches and pass them directly to PdfReader component |
| src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj | Updated PdfReader package version to support new ShowPrint parameter |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+30
to
+31
| <PdfReader Url="@_url" ShowTwoPagesOneView="_showTwoPagesOneView" | ||
| ShowDownload="_showDownload" ShowPrint="_showPrint" |
There was a problem hiding this comment.
Parameter bindings should use the '@' prefix for C# expressions. The parameters ShowTwoPagesOneView, ShowDownload, and ShowPrint are bound with quotes but no '@' prefix, which will pass them as string literals rather than boolean values. Change to ShowTwoPagesOneView="@_showTwoPagesOneView", ShowDownload="@_showDownload", and ShowPrint="@_showPrint".
Suggested change
| <PdfReader Url="@_url" ShowTwoPagesOneView="_showTwoPagesOneView" | |
| ShowDownload="_showDownload" ShowPrint="_showPrint" | |
| <PdfReader Url="@_url" ShowTwoPagesOneView="@_showTwoPagesOneView" | |
| ShowDownload="@_showDownload" ShowPrint="@_showPrint" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7190
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Add configurable controls for PdfReader demo to toggle download, print, and two-page view options.
New Features:
Enhancements: