feat(PdfReader): add localization doc #7195
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Reviewer's guide (collapsed on small PRs)Reviewer's GuideRefactors the PdfReaders sample component by removing unused properties, advanced demo logic, and attribute metadata helpers, leaving only the basic PdfReader demo state and download behavior. Class diagram for simplified PdfReaders sample componentclassDiagram
class PdfReaders_Before {
- DownloadService DownloadService
- string FileName
- string Filename
- PdfReader PdfReader
- bool _showTwoPagesOneView
- bool _showPrint
- bool _showDownload
- bool _showPager
- IWebHostEnvironment WebHostEnvironment
- string FilenameStream
- PdfReader AdvancedPdfReader
- bool StreamMode
- bool ReadOnly
- string Watermark
- EnumZoomMode Zoom
- EnumPageMode PageMode
- string Search
- int Page
+ Task OnDownloadAsync()
+ Task ApplyFilenameStream()
+ Task ApplyZoom()
+ Task ApplyPageMode()
+ Task Refresh()
+ Task ApplyPage()
+ Task ApplyPagePrevious()
+ Task ApplyPageNext()
+ Task ApplySearch()
+ Task Clear()
+ AttributeItem[] GetAttributes()
}
class PdfReaders_After {
- DownloadService DownloadService
- bool _showTwoPagesOneView
- bool _showPrint
- bool _showDownload
- bool _showPager
- IWebHostEnvironment WebHostEnvironment
+ Task OnDownloadAsync()
}
PdfReaders_Before <|-- PdfReaders_After
File-Level Changes
Assessment against linked issues
Possibly linked issues
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #7195 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 745 745
Lines 32583 32583
Branches 4515 4515
=========================================
Hits 32583 32583
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the PdfReader component demo by removing unused code and upgrading the package version from beta to stable release. The localization documentation already exists in the locale files (en-US.json and zh-CN.json), so this appears to be a cleanup refactor rather than adding new localization.
Key changes:
- Removed unused demo properties, methods, and the GetAttributes documentation method
- Updated BootstrapBlazor.PdfReader package from version 10.0.1-beta08 to 10.0.1 (stable)
- Simplified the code-behind file to only include actively used members
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| PdfReaders.razor.cs | Removed unused imports, properties, demo methods, and the GetAttributes method that documented component parameters |
| BootstrapBlazor.Server.csproj | Updated PdfReader package from beta (10.0.1-beta08) to stable release (10.0.1) |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link issues
fixes #7194
Summary By Copilot
Regression?
Risk
Verification
Packaging changes reviewed?
☑️ Self Check before Merge
Summary by Sourcery
Simplify the PdfReaders sample component by removing unused advanced properties, methods, and attribute metadata related to PDF viewing and documentation.
Enhancements: