Skip to content

chore(HikVision): remove AddBootstrapBlazorHikVision service#7285

Merged
ArgoZhang merged 1 commit intomainfrom
chore-hik
Dec 10, 2025
Merged

chore(HikVision): remove AddBootstrapBlazorHikVision service#7285
ArgoZhang merged 1 commit intomainfrom
chore-hik

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 10, 2025

Link issues

fixes #7284

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Stop registering the BootstrapBlazor HikVision service in the server DI setup to decouple HikVision from the default service pipeline.

Copilot AI review requested due to automatic review settings December 10, 2025 02:19
@bb-auto bb-auto Bot added the chore This are tasks or bot action label Dec 10, 2025
@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 10, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 10, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Removes registration of the HikVision network camera service from the shared BootstrapBlazor server service configuration, so HikVision is no longer wired into the default DI setup.

Class diagram for ServiceCollectionSharedExtensions after removing HikVision registration

classDiagram
    class IServiceCollection {
    }

    class ServiceCollectionSharedExtensions {
        +IServiceCollection AddBootstrapBlazorServices(IServiceCollection services)
        +IServiceCollection AddBootstrapBlazorRegionService(IServiceCollection services)
        +IServiceCollection AddBootstrapBlazorHikVision(IServiceCollection services)
    }

    class BootstrapBlazorRegionService {
    }

    class HikVisionCameraService {
    }

    ServiceCollectionSharedExtensions ..> IServiceCollection : extends
    ServiceCollectionSharedExtensions ..> BootstrapBlazorRegionService : registers
    %% HikVisionCameraService is no longer registered in AddBootstrapBlazorServices
    ServiceCollectionSharedExtensions ..> HikVisionCameraService : registration_requires_explicit_call
Loading

File-Level Changes

Change Details Files
Stop registering the HikVision network camera service in the shared BootstrapBlazor service collection extension.
  • Remove the AddBootstrapBlazorHikVision service registration from the AddBootstrapBlazorServices extension method.
  • Keep all other existing service registrations (e.g., region service, ORM comments) unchanged.
src/BootstrapBlazor.Server/Extensions/ServiceCollectionSharedExtensions.cs

Assessment against linked issues

Issue Objective Addressed Explanation
#7284 Remove the AddBootstrapBlazorHikVision service registration from the codebase (specifically from the common BootstrapBlazor service configuration).

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit d4dc195 into main Dec 10, 2025
5 of 6 checks passed
@ArgoZhang ArgoZhang deleted the chore-hik branch December 10, 2025 02:19
Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 10, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 100.00%. Comparing base (b964850) to head (fe0b258).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##              main     #7285   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files          745       745           
  Lines        32628     32628           
  Branches      4522      4522           
=========================================
  Hits         32628     32628           
Flag Coverage Δ
BB 100.00% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the explicit service registration call for the HikVision component and updates the package to version 10.0.4, which handles service registration internally.

  • Removed AddBootstrapBlazorHikVision() service registration call
  • Updated BootstrapBlazor.HikVision package from version 10.0.3 to 10.0.4

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor.Server/Extensions/ServiceCollectionSharedExtensions.cs Removed explicit HikVision service registration call that is no longer needed
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj Updated HikVision package version to 10.0.4 which auto-registers services

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

chore This are tasks or bot action

Projects

None yet

Development

Successfully merging this pull request may close these issues.

chore(HikVision): remove AddBootstrapBlazorHikVision service

2 participants