Skip to content

chore(Deploy): update sdk version to net10#7309

Merged
ArgoZhang merged 1 commit intomainfrom
chore-deploy
Dec 12, 2025
Merged

chore(Deploy): update sdk version to net10#7309
ArgoZhang merged 1 commit intomainfrom
chore-deploy

Conversation

@ArgoZhang
Copy link
Copy Markdown
Member

@ArgoZhang ArgoZhang commented Dec 12, 2025

Link issues

fixes #7308

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Build:

  • Change Linux deployment dependency to target dotnet-sdk-10.0.

Copilot AI review requested due to automatic review settings December 12, 2025 07:31
@bb-auto bb-auto Bot added the enhancement New feature or request label Dec 12, 2025
@bb-auto bb-auto Bot added this to the v10.1.0 milestone Dec 12, 2025
@sourcery-ai
Copy link
Copy Markdown
Contributor

sourcery-ai Bot commented Dec 12, 2025

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Updates the Linux deployment script to install .NET SDK 10.0 instead of 9.0, aligning the deployment environment with the new target SDK version.

Flow diagram for updated Linux deploy.sh installing dotnet-sdk-10.0

flowchart TD
    A[Start deploy.sh] --> B[Download packages-microsoft-prod.deb]
    B --> C[Install Microsoft package repository]
    C --> D[Remove packages-microsoft-prod.deb]
    D --> E[Run apt-get update]
    E --> F[Install dotnet-sdk-10.0]
    F --> G[End deploy.sh]
Loading

File-Level Changes

Change Details Files
Bump the .NET SDK version used in the Linux deployment script from 9.0 to 10.0.
  • Update the apt-get install command to request dotnet-sdk-10.0 instead of dotnet-sdk-9.0
  • Keep the rest of the deployment steps and package setup logic unchanged
scripts/linux/deploy.sh

Assessment against linked issues

Issue Objective Addressed Explanation
#7308 Update the deployment configuration/scripts to use the .NET 10 SDK instead of the previous SDK version.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

Copy link
Copy Markdown
Contributor

@sourcery-ai sourcery-ai Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey there - I've reviewed your changes - here's some feedback:

  • Consider extracting the .NET SDK version into a variable or configuration so future upgrades only require changing it in one place rather than hardcoding 10.0 in the script.
  • Double-check that other deployment or build scripts referencing dotnet-sdk-9.0 are updated to dotnet-sdk-10.0 as well to keep the toolchain version consistent across environments.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- Consider extracting the .NET SDK version into a variable or configuration so future upgrades only require changing it in one place rather than hardcoding `10.0` in the script.
- Double-check that other deployment or build scripts referencing `dotnet-sdk-9.0` are updated to `dotnet-sdk-10.0` as well to keep the toolchain version consistent across environments.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@ArgoZhang ArgoZhang merged commit ace10cf into main Dec 12, 2025
8 checks passed
@ArgoZhang ArgoZhang deleted the chore-deploy branch December 12, 2025 07:31
@ArgoZhang ArgoZhang changed the title feat(Deploy): update sdk version to net10 chore(Deploy): update sdk version to net10 Dec 12, 2025
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the .NET SDK version in the Linux deployment script from 9.0 to 10.0, aligning it with the rest of the codebase which has already been migrated to .NET 10.0.

  • Updates the dotnet-sdk package installation version from 9.0 to 10.0 in the Linux deployment script

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@codecov
Copy link
Copy Markdown

codecov Bot commented Dec 12, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.99%. Comparing base (f9aa99e) to head (b80557c).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #7309   +/-   ##
=======================================
  Coverage   99.99%   99.99%           
=======================================
  Files         745      745           
  Lines       32637    32637           
  Branches     4523     4523           
=======================================
  Hits        32636    32636           
  Partials        1        1           
Flag Coverage Δ
BB 99.99% <ø> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(Deploy): update sdk version to net10

2 participants