Skip to content

feat(UniverSheet): add LoadingText parameter#7497

Merged
ArgoZhang merged 2 commits intomainfrom
feat-sheet
Jan 11, 2026
Merged

feat(UniverSheet): add LoadingText parameter#7497
ArgoZhang merged 2 commits intomainfrom
feat-sheet

Conversation

@ArgoZhang
Copy link
Member

@ArgoZhang ArgoZhang commented Jan 11, 2026

Link issues

fixes #7496

Summary By Copilot

Regression?

  • Yes
  • No

Risk

  • High
  • Medium
  • Low

Verification

  • Manual (required)
  • Automated

Packaging changes reviewed?

  • Yes
  • No
  • N/A

☑️ Self Check before Merge

⚠️ Please check all items below before review. ⚠️

  • Doc is updated/provided or not needed
  • Demo is updated/provided or not needed
  • Merge the latest code from the main branch

Summary by Sourcery

Enhancements:

  • Clean up the UniverSheets sample CSS by correcting the .bb-sheet-demo selector formatting.

Copilot AI review requested due to automatic review settings January 11, 2026 08:42
@bb-auto bb-auto bot added the enhancement New feature or request label Jan 11, 2026
@bb-auto bb-auto bot added this to the v10.2.0 milestone Jan 11, 2026
@sourcery-ai
Copy link
Contributor

sourcery-ai bot commented Jan 11, 2026

Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

Minor cleanup in the UniverSheets sample styles: normalize the CSS file header so the .bb-sheet-demo class selector is defined without a leading BOM character; no functional changes are visible in the provided diff.

File-Level Changes

Change Details Files
Normalize UniverSheets demo CSS so the root class selector is a plain .bb-sheet-demo without an invisible BOM character.
  • Remove the UTF-8 BOM/invisible character before the .bb-sheet-demo selector in the UniverSheets sample CSS file header to ensure clean class naming and avoid potential tooling issues
src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor.css

Assessment against linked issues

Issue Objective Addressed Explanation
#7496 Add a LoadingText parameter to the UniverSheet component (including any necessary wiring in code and/or markup so it can be used). The diff only shows a minor change to the UniverSheets.razor.css file (removal of a BOM) and an unchanged .csproj entry. There are no code, markup, or parameter additions related to a LoadingText parameter.
#7496 Update any relevant sample/demo or documentation to demonstrate or describe the new LoadingText parameter for UniverSheet. The PR does not modify any sample component markup, demo files, or documentation content; only a CSS file was touched, with no functional or documentation changes.

Possibly linked issues


Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@ArgoZhang ArgoZhang merged commit 055377c into main Jan 11, 2026
4 of 6 checks passed
@ArgoZhang ArgoZhang deleted the feat-sheet branch January 11, 2026 08:42
Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey - I've left some high level feedback:

  • The PR title and description suggest adding a LoadingText parameter, but the only change here is a minor CSS tweak; please either update the PR metadata or include the intended functional changes so the diff aligns with the description.
Prompt for AI Agents
Please address the comments from this code review:

## Overall Comments
- The PR title and description suggest adding a LoadingText parameter, but the only change here is a minor CSS tweak; please either update the PR metadata or include the intended functional changes so the diff aligns with the description.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR updates the BootstrapBlazor.UniverSheet package to version 10.0.7, which includes the new LoadingText parameter feature mentioned in issue #7496. The changes also include a minor formatting fix to remove a BOM character from a CSS file.

Changes:

  • Updated BootstrapBlazor.UniverSheet package reference from version 10.0.6 to 10.0.7
  • Removed BOM (Byte Order Mark) character from UniverSheets.razor.css

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/BootstrapBlazor.Server/BootstrapBlazor.Server.csproj Updated BootstrapBlazor.UniverSheet package version to 10.0.7 to include the new LoadingText parameter
src/BootstrapBlazor.Server/Components/Samples/UniverSheets.razor.css Removed BOM character from the beginning of the CSS file

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(UniverSheet): add LoadingText parameter

1 participant