Fixed SQL content filter on IMonitoringApi.PostgreSql.cs#814
Merged
xiangxiren merged 1 commit intodotnetcore:masterfrom Mar 30, 2021
mviegas:fix/postgres-content-filter
Merged
Fixed SQL content filter on IMonitoringApi.PostgreSql.cs#814xiangxiren merged 1 commit intodotnetcore:masterfrom mviegas:fix/postgres-content-filter
xiangxiren merged 1 commit intodotnetcore:masterfrom
mviegas:fix/postgres-content-filter
Conversation
xiangxiren
approved these changes
Mar 30, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was trying to filter the Dashboard by some of the message properties (content) and it was not working. After investigating, found out that the generated SQL as wrong. Since the % is already placed within the NpgsqlParameter on the line 94, the filter on the line 84 was wrongly placed and can be simplified.
This fixes this issue and the content filter now behaves properly.