Skip to content

Add try catch on Dispatcher.Processing when invoke subscriber#900

Merged
yang-xiaodong merged 4 commits intodotnetcore:masterfrom
luox78:master
Jun 2, 2021
Merged

Add try catch on Dispatcher.Processing when invoke subscriber#900
yang-xiaodong merged 4 commits intodotnetcore:masterfrom
luox78:master

Conversation

@luox78
Copy link
Contributor

@luox78 luox78 commented Jun 2, 2021

No description provided.

@xiangxiren xiangxiren requested a review from yang-xiaodong June 2, 2021 00:58
@yang-xiaodong
Copy link
Member

Hello, There is a Try Catch inside the function to handle exceptions, there is no need to add additional

@luox78
Copy link
Contributor Author

luox78 commented Jun 2, 2021

Hello, There is a Try Catch inside the function to handle exceptions, there is no need to add additional

你好,里面catch处理的时候有个设置消息失败状态的操作,很可能有数据库导致抛出异常

@yang-xiaodong
Copy link
Member

Ah, you're right I miss that, thank you

Copy link
Member

@yang-xiaodong yang-xiaodong left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yang-xiaodong yang-xiaodong merged commit 1bc1595 into dotnetcore:master Jun 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants