Implement and align `DbType.Time` support across database dialects by Copilot · Pull Request #163 · dotnetprojects/Migrator.NET

Copilot · 2026-05-20T13:13:10Z

Inspect the new PR comment and investigate the failing CI/build using GitHub Actions logs
Reproduce the reported build failure locally and identify the minimal fix
Apply a surgical change and run targeted validation for the affected build/tests
Run final automated review/security validation and reply to the new comment

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/439a3240-c184-402f-8fb3-17c4aab1fbeb Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

jogibear9988 · 2026-05-20T14:18:25Z

@copilot also create tests

Copilot · 2026-05-20T14:20:10Z

@copilot also create tests

Added in dab1b02: ColumnPropertyMapperTest.SqlServerMapsTimeType for the dialect mapping and SQLServerTransformationProvider_AddTableTests.AddTableTime for the SQL Server provider path.

Copilot

Pull request overview

This PR fixes SQL Server handling of DbType.Time so that migrations can create real TIME columns and schema introspection can resolve SQL Server time metadata back to DbType.Time, preventing type round-trip mismatches.

Changes:

Map DbType.Time to SQL Server TIME in SqlServerDialect (instead of DATETIME).
Extend SQL Server schema introspection (GetColumns) to recognize time and map it to MigratorDbType.Time.
Add regression tests covering dialect-level mapping and provider-level add/readback for DbType.Time.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File	Description
`src/Migrator/Providers/Impl/SqlServer/SqlServerTransformationProvider.cs`	Adds schema metadata parsing for SQL Server `time` → `MigratorDbType.Time`.
`src/Migrator/Providers/Impl/SqlServer/SqlServerDialect.cs`	Changes dialect type mapping for `DbType.Time` to emit `TIME`.
`src/Migrator.Tests/Providers/SQLServer/SQLServerTransformationProvider_AddTableTests.cs`	Adds integration coverage to ensure `DbType.Time` round-trips via `AddTable` / `GetColumnByName`.
`src/Migrator.Tests/ColumnPropertyMapperTest.cs`	Adds unit coverage ensuring dialect maps `DbType.Time` ↔ database type name `time`.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

+                }
+                else if (dataTypeString == "time")
+                {
+                    column.MigratorDbType = MigratorDbType.Time;


Copilot · 2026-05-20T14:49:44Z

        RegisterColumnType(DbType.String, 4000, "NVARCHAR($l)");
        RegisterColumnType(DbType.String, int.MaxValue, "NVARCHAR(max)");
        //RegisterColumnType(DbType.String, 1073741823, "NTEXT");
-        RegisterColumnType(DbType.Time, "DATETIME");
+        RegisterColumnType(DbType.Time, "TIME");
        RegisterColumnType(DbType.VarNumeric, "NUMERIC(18,0)");


Addressed in 4596e13. SqlServerDialect.Default now emits quoted TimeSpan defaults for SQL Server TIME columns, and I added a focused test covering the generated SQL.

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/0ab9f682-2192-4257-b5e8-a8f5da25d152 Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

jogibear9988 · 2026-05-20T16:04:17Z

@copilot what about the other databases? We always should implement features for all

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/b2c708ee-90fa-4e09-a63d-f7ca8baf53cb Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

Copilot · 2026-05-20T16:17:04Z

@copilot also create tests

Added focused tests in f7aec93/980835d: cross-database dialect tests for DbType.Time, plus provider add-table coverage for SQLite and PostgreSQL alongside the existing SQL Server coverage.

@copilot what about the other databases? We always should implement features for all

Handled in f7aec93. I extended the follow-up beyond SQL Server by adding DbType.Time coverage for PostgreSQL, SQLite, and MySQL where the repo already has native TIME mappings, including quoted TimeSpan defaults for SQLite/MySQL and a shared exact-match fix so PostgreSQL time resolves correctly. Oracle/Firebird still need a separate design because they do not currently round-trip a native time-only type the same way.

jogibear9988 · 2026-05-20T20:31:48Z

@copilot the build fails, look after it

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/47922b64-b978-4b97-96e7-50d505b94852 Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

Copilot · 2026-05-20T20:44:25Z

@copilot the build fails, look after it

Fixed in 1027e03. The failing CI test was PostgreSQL AddTableTime: PostgreSQL reports native TIME columns as time without time zone, but PostgreSQLTransformationProvider.GetColumns only handled time. I updated the introspection mapping and re-ran dotnet build Migrator.slnx plus dotnet test Migrator.slnx successfully.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

1.0.0.127.in-addr.arpa
- Triggering command: /opt/mssql/bin/sqlservr (dns block)
metadata.google.internal
- Triggering command: /opt/mssql/bin/sqlservr (dns block)
settings-win.data.microsoft.com
- Triggering command: /opt/mssql/bin/sqlservr (dns block)
vortex.data.microsoft.com
- Triggering command: /opt/mssql/bin/sqlservr (dns block)
www.example.com
- Triggering command: /opt/oracle/product/26ai/dbhomeFree/bin/oracle oracleFREE (DESCRIPTION=(LOCAL=YES)(ADDRESS=(PROTOCOL=beq))) (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Configure Actions setup steps to set up my environment, which run before the firewall is enabled
Add the appropriate URLs or hosts to the custom allowlist in this repository's Copilot coding agent settings (admins only)

Initial plan

d3da175

Copilot AI assigned Copilot and jogibear9988 May 20, 2026

Copilot AI requested review from Copilot and removed request for Copilot May 20, 2026 13:13

Copilot started work on behalf of jogibear9988 May 20, 2026 13:13 View session

Copilot AI linked an issue May 20, 2026 that may be closed by this pull request

DbType.Time is not implemented #162

Open

Implement SQL Server DbType.Time support

dab1b02

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/439a3240-c184-402f-8fb3-17c4aab1fbeb Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 20, 2026 13:19

Copilot AI changed the title ~~[WIP] Implement DbType.Time for job time column~~ Implement SQL Server support for DbType.Time May 20, 2026

Copilot finished work on behalf of jogibear9988 May 20, 2026 13:24

Copilot AI requested a review from jogibear9988 May 20, 2026 13:24

Copilot started work on behalf of jogibear9988 May 20, 2026 14:18 View session

jogibear9988 marked this pull request as ready for review May 20, 2026 14:20

Copilot AI review requested due to automatic review settings May 20, 2026 14:20

Copilot finished work on behalf of jogibear9988 May 20, 2026 14:20

Copilot started reviewing on behalf of jogibear9988 May 20, 2026 14:21 View session

Copilot AI reviewed May 20, 2026

View reviewed changes

Copilot started work on behalf of jogibear9988 May 20, 2026 14:41 View session

Fix SQL Server TimeSpan defaults

4596e13

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/0ab9f682-2192-4257-b5e8-a8f5da25d152 Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

Copilot finished work on behalf of jogibear9988 May 20, 2026 14:50

Copilot started work on behalf of jogibear9988 May 20, 2026 16:04 View session

Extend DbType.Time coverage beyond SQL Server

980835d

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/b2c708ee-90fa-4e09-a63d-f7ca8baf53cb Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 20, 2026 16:13

Refine cross-database DbType.Time follow-up

f7aec93

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/b2c708ee-90fa-4e09-a63d-f7ca8baf53cb Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 20, 2026 16:15

Copilot AI changed the title ~~Implement SQL Server support for DbType.Time~~ Implement and align DbType.Time support across database dialects May 20, 2026

Copilot finished work on behalf of jogibear9988 May 20, 2026 16:17

Copilot started work on behalf of jogibear9988 May 20, 2026 20:31 View session

Fix PostgreSQL time column introspection

1027e03

Agent-Logs-Url: https://github.com/dotnetprojects/Migrator.NET/sessions/47922b64-b978-4b97-96e7-50d505b94852 Co-authored-by: jogibear9988 <364896+jogibear9988@users.noreply.github.com>

Copilot AI requested review from Copilot and removed request for Copilot May 20, 2026 20:42

Copilot finished work on behalf of jogibear9988 May 20, 2026 20:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Implement and align `DbType.Time` support across database dialects#163

Implement and align `DbType.Time` support across database dialects#163
Copilot wants to merge 6 commits into
masterfrom
copilot/implement-dbtype-time

Copilot AI commented May 20, 2026 •

edited

Loading

Uh oh!

jogibear9988 commented May 20, 2026

Uh oh!

Copilot AI commented May 20, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI May 20, 2026

Uh oh!

jogibear9988 commented May 20, 2026

Uh oh!

Copilot AI commented May 20, 2026 •

edited

Loading

Uh oh!

jogibear9988 commented May 20, 2026

Uh oh!

Copilot AI commented May 20, 2026 •

edited

Loading

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Uh oh!

Conversation

Copilot AI commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jogibear9988 commented May 20, 2026

Uh oh!

Copilot AI commented May 20, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI May 20, 2026

Choose a reason for hiding this comment

Uh oh!

jogibear9988 commented May 20, 2026

Uh oh!

Copilot AI commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

jogibear9988 commented May 20, 2026

Uh oh!

Copilot AI commented May 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

I tried to connect to the following addresses, but was blocked by firewall rules:

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented May 20, 2026 •

edited

Loading

Copilot AI commented May 20, 2026 •

edited

Loading

Copilot AI commented May 20, 2026 •

edited

Loading