fix RtpPacket and RtcpPacket bitmask setter logic#209
Merged
PhyxionNL merged 1 commit intodotpcap:masterfrom Aug 4, 2024
Merged
fix RtpPacket and RtcpPacket bitmask setter logic#209PhyxionNL merged 1 commit intodotpcap:masterfrom
PhyxionNL merged 1 commit intodotpcap:masterfrom
Conversation
previous logic only worked on zeroed data, it could not update existing packets
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The PayloadType setter uses
header[offset] |= value & bitmaskto set the value.However this only sets the bits in the new value, it does not unset existing bits not in the value. While the setter works when the current header byte is zero, it fails if the RTP header already has a payload type value to be changed.
The same bug also appears to affect ReceptionReportCount and CsrcCount.