Skip to content

Major optimization of audio size and safari audio fix #667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 81 commits into from
Oct 30, 2020
Merged

Major optimization of audio size and safari audio fix #667

merged 81 commits into from
Oct 30, 2020

Conversation

@orsi
Copy link
Contributor

@orsi orsi commented Oct 13, 2020 •
edited
Loading

Major optimization of audio files due to two factors:

  1. Total audio assets size reduced from 20.3MB to 5MB
  2. Removed preloaded audio, as this was initially downloading 10.8MB of audio on first load if not cached in browser. This was most likely the reason why your bandwidth was out of control (very, very sorry for this)

Fixed the issue with Safari breaking on landmark audio error. In fact, this was due to an issue in Safari not having a promise API for a Web Audio function that all other browsers have, and was causing Safari to not play audio when loaded, but only on subsequent plays. I've now made it work properly on first load for all browsers.

orsi added 30 commits May 28, 2020 19:10
@orsi
initial start for audio support
9ae328d
@orsi
rough implementation for changing background music
978f53d
@orsi
add basic outline of audio for room
12c6559
@orsi
add outline of outside audio
7df6284
@orsi
add rest of sound definitions for room
39fbd16
@orsi
add more sound effect definitions
de9d2e6
@orsi
add outline of Path sounds
9ae1ac0
@orsi
add outline of world sounds
1f8dbc1
@orsi
add Room craft* sound effect definitions
bd51940
@orsi
add more sound definitions
c35912b
@orsi
add outline of ship sounds
f188f45
@orsi
add more room sounds definitions
221a970
@orsi
add outline of ship sounds
d951755
@orsi
add outline of space sounds
21267e3
@orsi
add majority of sound definitions
71786c3
@orsi
connect majority actions to sound effects;add more placeholder loops …
1d84e5f 
…and effects
@orsi
add button to turn volume on and off
8db47ce
@orsi
remove logging
3c6a386
@orsi
play music on landmark events
2013269
@orsi
create AudioLibrary module to consolidate audio
a340584
@orsi
refactor audio-related code to use AudioLibrary module
18e8af9
@orsi
add audioLibrary to scripts
3adf493
@orsi
prototype fire sounds
d3f1d9c
@orsi
fix music not starting on arrival when fire is dead
1d4f48b
@orsi
rough outline for room audio
113596f
@orsi
add rough songs for outside
17b21be
@orsi
add rough outline of path and world'
274f20e
@orsi
make audio urls relative
6b5acb9
@orsi
add full path to audio sources when fetching
fc7b72f
@orsi
lower event music volume for now -- way too loud relative to main
e2845c1
orsi added 28 commits June 3, 2020 16:24
@orsi
remove unused audio references
986d76a
@orsi
reorganize audio library order
a5d81c2
@orsi
refactor functions
3a2819d
@orsi
preload high priority area and event audio
fd4fbe6
@orsi
refactor audio engine: simplified gain channels, improve fading betwe…
3b43a27 
…en audio, rename functions
@orsi
fix room music playing when in another scene
44a7552
@orsi
fix space music fading in when ending game by adding separate backgro…
783886b 
…und volume function
@orsi
fix wrong function call
031d943
@orsi
reorder enable god mode code to prevent duplicate area tabs
8dea25c
@orsi
add missing event music; lower volume for space music
ed05aee
@orsi
add missing sound effects
54e6731
@orsi
prevent same sound from playing multiple times
a5c81f1
@orsi
improve footstep sounds
dc3184e
@orsi
improve audio
2b0d1b7
@orsi
improve encounter music
b099a1d
@orsi
fix enableGodMode order to prevent strange behaviour
51ddd24
@orsi
normalize volume levels of sound effects that were too loud
dafc863
@orsi
fix audio context resuming for browsers with no autoplay policy
f6b7a35
@orsi
fix invalid state error in safari when trying to stop background music
2a7f844
@orsi
fix sound turning on/off randomly on first user click due to toggleVo…
e260dcf 
…lume call
@orsi
restore original google analytics
da51fd0
@orsi
remove god mod function
371c657
@orsi
fix jshint warning about leading decimals confused for dot properties
c1f0e70
@orsi
Merge branch 'master' of https://github.com/doublespeakgames/adarkroom …
9a75688 
…into doublespeakgames
@orsi
merge upstream/main
d0a12ac
@orsi
fix safari audio bug where error prevents leaving worldmap locations …
9d80499 
…-- reveals another safari bug where decodeAudioData doesn't return a promise to start playing music immediately
@orsi
reduce audio file sizes by converting to mmono, lowering sample rate …
af34686 
…to 22k from 44k, and lowering bit depth to 16bit from 24bit
@orsi
remove audio preload
817dece
@orsi orsi mentioned this pull request Oct 13, 2020
Closed
@Continuities Continuities merged commit f8b3c03 into doublespeakgames:main Oct 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@orsi @Continuities