Skip to content

Structure members need to be checked for variables#31

Merged
dougpuob merged 15 commits intodougpuob:masterfrom
neville1:master
Feb 14, 2020
Merged

Structure members need to be checked for variables#31
dougpuob merged 15 commits intodougpuob:masterfrom
neville1:master

Conversation

@neville1
Copy link
Copy Markdown
Contributor

@neville1 neville1 commented Feb 6, 2020

why:
Structure members need to be checked for variables
How To Fix:
Expand inspection scope
Reviewer:
DouglasDouglas.Chen@genesyslogic.com.tw

why:
Structure members need to be checked for variables
How To Fix:
Expand inspection scope
Reviewer:
Douglas<Douglas.Chen@genesyslogic.com.tw>
why:
because struct field need to check

How To Fix:
Field need to be check.

Reviewer:
Douglas<Douglas.Chen@genesyslogic.com.tw>
Why:
struct member need to be check.

How To Fix:
check field decl

Reviewer:
Douglas<Douglas.Chen@genesyslogic.com.tw>
Why:
want to test pr process
How to Fix:
None.
Reviewer:
None.
Why:
want to test pr process
How to Fix:
None.
Reviewer:
None.
Why:
1.function count is not correct.
2.argument have better way for detection
3.if some variable don't have name, it does not need to be checked.

Reviewer:
Douglas<Douglas.Chen@genesyslogic.com.tw>
Comment thread Source/MyAstVisitor.cpp Outdated
Comment thread Source/MyAstVisitor.cpp Outdated
Comment thread Source/MyAstVisitor.h Outdated
@dougpuob
Copy link
Copy Markdown
Owner

OK

@dougpuob dougpuob closed this Feb 14, 2020
@dougpuob dougpuob reopened this Feb 14, 2020
@dougpuob dougpuob merged commit 509c0b4 into dougpuob:master Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants