fix warnings across event-graph-walker, loom, alga, lang/markdown#754
Merged
Conversation
event-graph-walker: Rle::new->Rle::Rle, try?->try+Ok, bump rle 0.2.2->0.2.3 loom: update submodule pointers for egglog+egraph warning fixes alga: remove unused impl, suppress unused_value lang/markdown: suppress unused_package warning (loomproj used by wbtests)
|
Warning Review limit reached
More reviews will be available in 44 minutes and 5 seconds. Learn how PR review limits work. Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file). ⌛ How to resolve this issue?After more reviews become available, a review can be triggered using the To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits. 🚦 How do rate limits work?CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate. For paid Pro and Pro+ PR reviews, CodeRabbit uses rolling per-developer review limits. Reviews become available again as older review attempts age out of the rolling limit window. Please see our Fair Usage Limits Policy for further information. ℹ️ Review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThree submodule commit pointers ( ChangesSubmodule Updates and Package Config
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Possibly related PRs
Suggested labels
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
lambda-editor | 3e2a42a | Commit Preview URL Branch Preview URL |
Jun 23 2026, 02:56 PM |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b569390a8d
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: e70cc2dd13
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Benchmark Comparison ReportComparing PR branch against Main Module BenchmarksBase branch: PR branch: event-graph-walker BenchmarksBase branch: PR branch: Benchmarks run with |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@event-graph-walker`:
- Line 1: The event-graph-walker submodule pointer is pinned to commit SHA
edfe8ce1feae052dd86c286d0179b615c3aaf9a4, which does not exist or is
inaccessible in the submodule repository. Verify the correct commit SHA that
should be targeted in the event-graph-walker repository by checking the
repository history and ensuring it is a valid, existing commit. Update the
submodule reference to point to the correct, valid commit SHA that exists
upstream, then verify the submodule can be fetched successfully before pushing
the changes.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: f50134d8-5df8-47ca-b31c-cfd90f93bae6
📒 Files selected for processing (4)
algaevent-graph-walkerlang/markdown/proj/moon.pkgloom
| @@ -1 +1 @@ | |||
| Subproject commit 0ed747a5e55c4eb1ac9e336acf732a4939ed87b9 | |||
| Subproject commit edfe8ce1feae052dd86c286d0179b615c3aaf9a4 | |||
There was a problem hiding this comment.
🗄️ Data Integrity & Integration | 🔴 Critical
🧩 Analysis chain
🏁 Script executed:
#!/bin/bash
set -euo pipefail
TARGET_SHA="edfe8ce1feae052dd86c286d0179b615c3aaf9a4"
echo "Superproject gitlink entry:"
git ls-tree HEAD event-graph-walker
if [ -d "event-graph-walker" ]; then
echo
echo "Checking submodule commit existence and metadata:"
git -C event-graph-walker rev-parse --verify "${TARGET_SHA}^{commit}"
git -C event-graph-walker show --no-patch --pretty=fuller "${TARGET_SHA}"
echo
echo "Recent submodule history (for manual provenance check):"
git -C event-graph-walker log --oneline --decorate -n 30
else
echo "Submodule directory not present in this checkout; verify in CI or a full clone with submodules initialized."
fiRepository: dowdiness/canopy
Length of output: 483
Submodule pointer targets non-existent commit — verification failed.
The gitlink update pins event-graph-walker to commit edfe8ce1feae052dd86c286d0179b615c3aaf9a4, but this SHA cannot be resolved in the submodule repository. The system returned "not our ref" and "could not fetch from promisor remote", indicating the commit does not exist or is inaccessible. Verify the SHA is correct and exists upstream before merging.
🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
In `@event-graph-walker` at line 1, The event-graph-walker submodule pointer is
pinned to commit SHA edfe8ce1feae052dd86c286d0179b615c3aaf9a4, which does not
exist or is inaccessible in the submodule repository. Verify the correct commit
SHA that should be targeted in the event-graph-walker repository by checking the
repository history and ensuring it is a valid, existing commit. Update the
submodule reference to point to the correct, valid commit SHA that exists
upstream, then verify the submodule can be fetched successfully before pushing
the changes.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3e2a42a639
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -1 +1 @@ | |||
| Subproject commit d2c6c34157da4c8f0def90ec0c71bc366b5111e2 | |||
| Subproject commit aa26fe00bbc346a7414ddc99b7d19b77a9ec4709 | |||
There was a problem hiding this comment.
The loom pointer now includes the new indented-code implementation where examples/markdown/lexer.mbt builds IndentedCodeText from input[end:line_end] after end has skipped all leading whitespace, and markdown_ir.mbt trims leading whitespace again. For indented code lines with more than the required four columns (for example x), CommonMark removes only one 4-column indent and should preserve the remaining two spaces, but this revision renders the content as x, corrupting Markdown code blocks that intentionally contain leading whitespace.
Useful? React with 👍 / 👎.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix deprecated API warnings in workspace (excluding rabbita).
Changes:
Rle::new()→Rle::Rle(),try?→try{Ok(...)}, bump rle 0.2.2→0.2.3impl DirectedGraph, suppress unused_value@loomprojused by wbtests)Submodule PRs:
Summary by CodeRabbit