Skip to content

test: add runtime atomics and malformed frontmatter coverage#402

Merged
dowdiness merged 4 commits into
mainfrom
chore/test262-atomics-runtime-followup
Jun 18, 2026
Merged

test: add runtime atomics and malformed frontmatter coverage#402
dowdiness merged 4 commits into
mainfrom
chore/test262-atomics-runtime-followup

Conversation

@dowdiness

Copy link
Copy Markdown
Owner

Summary

  • Add execution-level regression coverage for Atomics timeout coercion/capping in test262 harness preamble.
    • New async whitebox test "atomics short timeout wrapper passes coerced timeouts at runtime" in tooling/test262_runner/runner_wbtest.mbt.
    • Runs the generated short-profile harness in Node and verifies Atomics.wait timeout arguments are normalized as expected.
  • Extend fallback regression coverage for malformed frontmatter metadata.
    • Existing fallback test now includes a malformed frontmatter fixture and asserts test task fallback still expands to both strict/non-strict modes.

Validation

  • moon test --target native tooling/test262_runner (9/9)
  • moon test --target native (2183/2183)

@coderabbitai

coderabbitai Bot commented Jun 18, 2026

Copy link
Copy Markdown

Warning

Review limit reached

@dowdiness, we couldn't start this review because you've reached your PR review rate limit.

More reviews will be available in 2 minutes and 51 seconds. Learn how PR review limits work.

Your organization has used up its prepaid credits, and credit purchases are no longer available. Enable the review add-on in the billing tab to keep reviews running — you're only billed for reviews past your plan's rate limits ($0.25/file).

⌛ How to resolve this issue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based credits.

🚦 How do rate limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan refill rate.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, the refill rate gradually slows as usage increases. The highest same-day bursts are limited more strictly.

Please see our Fair Usage Limits Policy for further information.

ℹ️ Review info
⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Pro

Run ID: ad7f4803-ae17-4a69-aa38-bb2db18538e5

📥 Commits

Reviewing files that changed from the base of the PR and between 3f49b1e and d8d5f5f.

📒 Files selected for processing (1)
  • tooling/test262_runner/runner_wbtest.mbt
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch chore/test262-atomics-runtime-followup

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 862d7c25a0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tooling/test262_runner/runner_wbtest.mbt Outdated
@dowdiness dowdiness merged commit 1066ed4 into main Jun 18, 2026
13 checks passed
@dowdiness dowdiness deleted the chore/test262-atomics-runtime-followup branch June 18, 2026 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant