[useSelect] Selecting item with spacebar in firefox reopens the menu

[lyml]

• downshift version: 6.0.6
• firefox version: 82.0.3

Relevant code or config

Error present in reference implementation: https://www.downshift-js.com/use-select

What you did:

With firefox, open a menu and select an item with the spacebar key

What happened:

The item was selected, but the menu was reopened. Closely inspecting the result of onStateChange it is revelead that on key down the __menu_keydown_space_button__ is emitted, and on key up the __togglebutton_click__ is emitted.

Error is not present in chrome.

Reproduction repository:

Problem description:

Suggested solution:

[silviuaavram]

Indeed it happens on Firefox. Can someone investigate?

Thanks for reporting the issue!

[rtt63]

Actually, this can be reproduced with Chrome by holding space pressed a little longer. However, on Firefox __togglebutton_click__ fires immediately

[silviuaavram]

If you can dig into this and even better provide a fix it would be super awesome! Thanks!

[lyml]

I'm not familiar with the downshift codebase but I can take a closer look sometime during the holidays.

[peterjcaulfield]

Looks this could be related to this FF bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=1552419

as this prevent default doesn't seem to prevent an onClick event firing for the spacebar onKeyUp.