fix(getHighlightedIndexOnOpen): remove added check from migration#1692
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR fixes a regression in getHighlightedIndexOnOpen introduced during the TS migration by ensuring -1 (meaning “no highlighted item”) is treated as an intentional, valid highlighted index on menu open—preventing selected-item logic from overriding that state and causing off-by-one navigation behavior.
Changes:
- Allow
initialHighlightedIndex === -1to be returned when it matches the current state highlighted index. - Allow
defaultHighlightedIndex === -1to be returned (even whenselectedItemis set), restoring intended precedence. - Add unit tests covering the
-1regression scenarios.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/hooks/utils/getHighlightedIndexOnOpen.ts |
Restores -1 handling for initial/default highlighted index on open. |
src/hooks/utils/__tests__/getHighlightedIndexOnOpen.test.ts |
Adds tests to prevent regressions when -1 should be preserved. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
🎉 This PR is included in version 9.3.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request
What
Removed added check during the TS migration PR.
Fixes #1688
Why
Causes a regression when opening the menu with a -1 highlighted index.
How
Remove the previously added guard.
Changes
Change getHighlightedIndexOnOpen to remove the guard.
Checklist