fix: 🐛 set sas_path target to mode = "always" to detect new SAS files in input_dir#233
Merged
lwjohnst86 merged 1 commit intomainfrom Feb 27, 2026
Merged
Conversation
…iles in `input_dir`
Contributor
Author
|
Another solution could be to refactor |
lwjohnst86
approved these changes
Feb 27, 2026
Member
lwjohnst86
left a comment
lwjohnst86
left a comment
There was a problem hiding this comment.
Makes sense 👍 yea, I mean, they can control the files via the command = list_sas_files... but not sure we want to implement that.
github-project-automation
bot
moved this from In review
to Approved
in Platform development
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I experienced that after adding more SAS files to the input_dir, the new files weren't converted. This fixes that.
Not sure how often this would happen though?
Needs a thorough review.
Checklist
just run-all