docs(conformance): add shapeMatchesSchema to P1-003 connect step (corpus consistency)#209
Merged
Merged
Conversation
…pus consistency)
P1-003 ("v1 protocolVersion bumped on connect") was the only assertion
step in the presence-protocol conformance corpus whose expect block
lacked a shapeMatchesSchema, despite the corpus description stating the
harness "verifies shapes against the JSON Schemas". Every other
expect-bearing step shape-validates; setup-only steps (no expect block)
correctly do not.
Adds the v0 connect output schema URI (verbatim mirror of P0-001 — the
connect schema is shared at v0/tools/hestia_connect.schema.json with no
v1 variant; its $defs/output admits protocolVersion:1). Contract-neutral
for assertion semantics: adds a shape check the response already
satisfies. No scenario-count or lastUpdated change.
Resolves the non-blocking gap flagged on PR #208 (issuecomment-4477974582),
pre-sanctioned by the prior session's recorded next-session signal.
Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Owner
Author
|
APPROVED: Single-line corpus-consistency follow-up to merged #208. Adds the one missing |
dp-web4
added a commit
that referenced
this pull request
May 19, 2026
…tion) PR #210 (3f12462) revealed 3 of 8 documented xfails were vector-spec staleness, not architectural gaps — vectors authored before Sprints 44/47/48 strengthened invariants. Suite now 34 passed / 5 xfailed. Executive Summary line 41 corrected from "8 xfailed gaps documented for the next operator architectural-decision pass" to "5 xfailed gaps awaiting operator architectural decisions" — sharpens framing alongside the count fix to disambiguate vector errors from operator-decision-bound gaps. PUBLISHER_CONTEXT.md updated with 2026-05-19 entry covering #208/#209/#210/#211. md + docs/whitepaper-web artifacts rebuilt; PDF/web not refreshed (prose edit only, no structure change). Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Single-line corpus-consistency follow-up to PR #208 (merged
ac9de279, C5-G4).P1-003 (
v1 protocolVersion bumped on connect) was the only assertion step in the presence-protocol conformance corpus whoseexpectblock lacked ashapeMatchesSchema— despite the corpus's own top-leveldescriptionstating the harness "verifies shapes against the JSON Schemas in schemas/presence-protocol/{v0,v1}/". This adds it, mirroring P0-001 verbatim.https://web4.io/schemas/presence-protocol/v0/tools/hestia_connect.schema.json#/$defs/output. The connect schema is shared atv0/tools/(there is nov1/tools/hestia_connect.schema.json); its$defs/outputhasprotocolVersion: {type: integer, minimum: 0}so aprotocolVersion: 1connect payload validates against it — exactly as P0-001 (aprotocol_version: 0connect) already uses the same schema.expectblock) shape-validate; setup steps (state-prep, onlyinput/capture, noexpect) correctly do not. Post-fix: steps with anexpectblock but noshapeMatchesSchema= 0. P1-003 was the sole violator across all 17 tool steps / 14 scenarios.lastUpdated(2026-05-18) unchanged.This resolves the non-blocking gap flagged on PR #208 (issuecomment-4477974582), pre-sanctioned by the prior session's recorded next-session signal and previously part of that session's policy-approved scope.
Provenance
v2 autonomous session protocol — propose → policy review (APPROVED, all 6 criteria) → execute → document. Session log:
private-context/autonomous-sessions/legion-web4-20260518-120044-session.md.Test plan
expect-bearing step carriesshapeMatchesSchema(0 violations post-fix)lastUpdatedunchanged🤖 Generated with Claude Code