Optargs#45
Merged
dparrish merged 4 commits intodparrish:Optargsfrom Jul 20, 2019
Merged
Conversation
CLI_CMD_SPOT_CHECK is designed to allow a 'spot check' to ensure that the optargs seen so far are 'sane' to allow parsing to continue. The check will *only* be done if there are no potential candidates at the point where the spot check is being evaluated. The recommended place to put any spot check is immediately prior to any command that would need 'sane' arguments to continue.
…sage if a conflict with an optarg found
dparrish
approved these changes
Jul 20, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added new 'CLI_CMD_SPOT_CHECK' optarg to allow for sanity checking of required optargs before proceeding with command line evaluation. The developer would insert a spot check before any place in the evaluation of arguments where evaluation should not continue if the required optarg state is incorrect.
The clitest.c program show this. Before entering the 'shape' optarg we need to have at least one of 'transparent' and 'color' set, but we can not have 'transparent' if 'color' is set to 'black'.
Added show/unset to the restricted commands when trying to enter buildmode, and made some comment changes.