V1.10.3 merge #57
Merged
V1.10.3 merge #57
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 7 commits
November 14, 2019 13:41
…eserving quoted strings - cli_parse_line now handles mixed quotes, escaped quotes, and treats a non-escaped, non-internal quote as a word boundary like a space/pipe/end-of-string - buildmode will preserve any string with space, quotes, or empty string by wrapping it in an appropriate quote pair when rebuilding the commandline to be executed
- If a CLI_CMD_OPTIONAL_FLAG optarg does not have a validator then the word being examined must match the name of the flag exactly - If a CLI_CMD_OPTIONAL_FLAG optarg does have a validator, then the validator must return CLI_OK for that to be a match Example - given a pseudosyntax 'CMD [verbose] ARG1' where verbose is the OPTIONAL FLAG then the text 'CMD ARG1' and 'CMD verbose ARG1' would match, but 'CMD VERBOSE ARG1' would not. If the OPTIONAL FLAG had a validator that did a strcasecmp with 'verbose' then it would match. The validator also allows this syntax: 'CMD [INTVAL] FOO' *if* the validator for INTVAL was written to return CLI_OK if the text for INTVAL was an integer
…'after' the triggering optarg
…i generates 'help' message output
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From changelog in libcli.spec....
to some comments, minor cosmetic change to clitest demo code
which buildmode was entered.
Designed to be called from a callback to show output of optarg and
argument processing.
(if provided) to determine if the word being looked is a match for
the optional flag. If no validator function is provided then the
word much match the name of the optional flag exactly.
line. This includs mixed single/double quotes, embedded quoted
substrings, and handling 'escaped' quotes using the '' character.
(ex: "", or '') when regenerating the cmdline after the user 'executes'
the command.