-
Notifications
You must be signed in to change notification settings - Fork 14
[SD-1218] Improve api error handling #1616
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for ripple-docs canceled.
|
ripple-framework
|
||||||||||||||||||||||||||||
| Project |
ripple-framework
|
| Branch Review |
feat/improve-api-error-handling
|
| Run status |
|
| Run duration | 15m 12s |
| Commit |
|
| Committer | Jason Smith |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
|
0
|
|
|
4
|
|
|
0
|
|
|
0
|
|
|
284
|
| View all changes introduced in this branch ↗︎ | |
64f86a2 to
0e805de
Compare
Member
Author
|
This seems to be caused by where the error happens - we currently deal with a 404 returned at the node, but this one was found when an endpoint returned 404 at the route instead. Before: After: |
jeffdowdle
approved these changes
Sep 18, 2025
dylankelly
approved these changes
Sep 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: https://digital-vic.atlassian.net/browse/SD-1218
What I did
How to test
Checklist
For all PR's
For new UI components only
emitRplEvent