fix: unix socket locking broken on darwin #3
Conversation
dpc
force-pushed
the
dpc/jj-qqxqqrnmzztz
branch
5 times, most recently
from
19093f1 to
e6bf087
Compare
| use std::io::Read as _; | ||
|
|
||
| // ignore, we *will* disconnect, nothing interesting about it | ||
| let _ = s.read(&mut [0]); |
There was a problem hiding this comment.
@dpc maybe calling read was reason it was hanging on macos?
just drop(s) feels like the better implementation to me 🤷
There was a problem hiding this comment.
It is supposed to hang. We're waiting for whoever is holding the lock to disconnect.
It was hanging on Darwin, because on Darwin when the process creating/binding Unix Socket is gone, the socket remains (unlike on Linux), and attempts to connect to it do not disconnect but just wait forever until something new binds on it.
There was a problem hiding this comment.
so clear_lock() is for waiting for lock?
There was a problem hiding this comment.
It waits for the lock to clear? Or it waits to clear the lock? Or it waits for me to get better at naming stuff? :D
No description provided.