Developer documentation pipeline deployment fix#408
Merged
dphfox merged 1 commit intodphfox:mainfrom Jan 24, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It seems that mkdocs for some reason hangs (or takes long enough to process for the difference to not matter) when it finds consecutive comments; file size and code block length must have something to do with it.
Also seems to not like multiline comments. When testing on my machine if I were to turn turn the changed comments into just one line I'd get a speed increase of almost 30% for the whole deployment.
Worth noting down somewhere for the future in contribution guidelines? Couldn't find any related issues on the internet