Skip to content

fix: error propagation in chat completions#1532

Merged
AlpinDale merged 4 commits into
mainfrom
debug_chat
Sep 26, 2025
Merged

fix: error propagation in chat completions#1532
AlpinDale merged 4 commits into
mainfrom
debug_chat

Conversation

@AlpinDale

Copy link
Copy Markdown
Member

No description provided.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AlpinDale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an issue with error propagation in chat completions by standardizing the format of HTTP exception responses. It modifies the http_exception_handler to wrap error messages, types, and codes within a dedicated ErrorInfo object, which is then used to construct the ErrorResponse. This ensures that API consumers receive a consistent and well-defined error structure when an HTTPException occurs.

Highlights

  • Error Response Structure: The pull request refactors the error response structure for HTTP exceptions, encapsulating error details within an ErrorInfo object.
  • Consistent Error Propagation: This change ensures that HTTP exceptions are propagated with a standardized and consistent error format, improving API reliability.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request correctly fixes a bug in the http_exception_handler. The change ensures that HTTPExceptions are properly serialized into the OpenAI-compatible error format by wrapping the error details in an ErrorInfo object before creating the ErrorResponse. This is a good fix that improves the robustness and correctness of error handling in the API server.

@AlpinDale AlpinDale merged commit fbbdbc4 into main Sep 26, 2025
0 of 4 checks passed
@AlpinDale AlpinDale deleted the debug_chat branch September 26, 2025 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant