Skip to content

[build] fix: relax xformers dependency version#1536

Merged
AlpinDale merged 4 commits into
mainfrom
fix_xformers_dep
Sep 27, 2025
Merged

[build] fix: relax xformers dependency version#1536
AlpinDale merged 4 commits into
mainfrom
fix_xformers_dep

Conversation

@AlpinDale

Copy link
Copy Markdown
Member

Fixes #1535

Looks like xformers regularly deletes their pre-releases, so we should just set the version to anything above 0.0.32.post2 to support pytorch 2.8 + cuda 12.8.

@gemini-code-assist

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello @AlpinDale, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request aims to enhance the robustness of the build process by making the xformers dependency more flexible. By switching from a specific pre-release version to a minimum version requirement, it mitigates issues caused by the frequent removal of xformers pre-releases, thereby ensuring smoother installations and compatibility with PyTorch 2.8 and CUDA 12.8.

Highlights

  • Dependency Version Relaxation: The version constraint for the xformers library has been relaxed in requirements/cuda.txt from an exact pre-release version to a minimum version.
  • Build Stability Improvement: This change addresses an issue where xformers pre-release versions are frequently deleted, which can cause build failures and instability.
  • Compatibility: The updated dependency ensures continued support for environments running PyTorch 2.8 and CUDA 12.8.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request relaxes the xformers dependency to prevent build failures caused by deleted pre-release versions. While this is a good improvement for build stability, using an unbounded version range (>0.0.32.post2) introduces the risk of pulling in future xformers versions with breaking changes. I've suggested adding an upper bound to the version specifier to mitigate this risk, which aligns with existing dependency management practices in this repository.

Comment thread requirements/cuda.txt Outdated
@AlpinDale AlpinDale merged commit 3db3eb3 into main Sep 27, 2025
0 of 4 checks passed
@AlpinDale AlpinDale deleted the fix_xformers_dep branch September 27, 2025 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

1 participant