Skip to content

[mm] fix: missing cached item in beam search#1577

Merged
AlpinDale merged 1 commit into
mainfrom
mm-beam
Nov 4, 2025
Merged

[mm] fix: missing cached item in beam search#1577
AlpinDale merged 1 commit into
mainfrom
mm-beam

Conversation

@AlpinDale

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: AlpinDale <alpindale@gmail.com>
@AlpinDale AlpinDale merged commit da3b8cf into main Nov 4, 2025
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to fix an issue with missing cached items in beam search for multimodal models by removing a preprocessing step. While this is a valid approach to prevent double expansion of placeholders, it introduces a regression where mm_processor_kwargs are always set to None, ignoring any values passed in the prompt. This could break multimodal beam search for models that depend on these arguments. I have provided a code suggestion to correctly extract these kwargs from the prompt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant