Conversation
Signed-off-by: AlpinDale <alpindale@gmail.com>
Contributor
There was a problem hiding this comment.
Code Review
This pull request aims to fix an issue with missing cached items in beam search for multimodal models by removing a preprocessing step. While this is a valid approach to prevent double expansion of placeholders, it introduces a regression where mm_processor_kwargs are always set to None, ignoring any values passed in the prompt. This could break multimodal beam search for models that depend on these arguments. I have provided a code suggestion to correctly extract these kwargs from the prompt.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.