Skip to content

[spec] remove unused args in spec decoding#1579

Merged
AlpinDale merged 1 commit into
mainfrom
cleanup-spec
Nov 4, 2025
Merged

[spec] remove unused args in spec decoding#1579
AlpinDale merged 1 commit into
mainfrom
cleanup-spec

Conversation

@AlpinDale

Copy link
Copy Markdown
Member

No description provided.

Signed-off-by: AlpinDale <alpindale@gmail.com>

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request focuses on improving code quality by removing unused arguments from the speculative decoding configuration. Specifically, disable_logprobs, enable_chunked_prefill, and disable_log_stats have been removed from SpeculativeConfig as they were not being used, which cleans up the configuration and reduces potential confusion. The changes are consistently applied across configuration and argument parsing files. Additionally, a helpful assertion was added in the OpenAI API server to ensure an engine client instance is valid before use, enhancing the code's robustness. Overall, these are good maintainability improvements and I see no issues.

@AlpinDale AlpinDale merged commit 6d77777 into main Nov 4, 2025
1 check passed
@AlpinDale AlpinDale deleted the cleanup-spec branch November 4, 2025 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant