Skip to content

[chore] pydantic validation for scheduler and structured outputs configs#1580

Merged
AlpinDale merged 1 commit into
mainfrom
sched-structured-pydantic
Nov 4, 2025
Merged

[chore] pydantic validation for scheduler and structured outputs configs#1580
AlpinDale merged 1 commit into
mainfrom
sched-structured-pydantic

Conversation

@AlpinDale

Copy link
Copy Markdown
Member

No description provided.

@AlpinDale AlpinDale merged commit 205877b into main Nov 4, 2025
1 check passed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request refactors the configuration classes for the scheduler and structured outputs to use pydantic's validation features more idiomatically. The changes replace manual validation in __post_init__ or model validators with pydantic.Field constraints and field_validator. This generally improves code clarity and correctness. However, I've identified one potential issue where moving validation from a model_validator to Field validators changes the validation timing, potentially leaving values modified in __post_init__ unvalidated. This could lead to issues in the future.

@AlpinDale AlpinDale deleted the sched-structured-pydantic branch November 4, 2025 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant