3052102 revisionable#1
Open
dpi wants to merge 11 commits into
Open
Conversation
jibran
reviewed
May 20, 2019
jibran
reviewed
May 20, 2019
| // Update existing fields. | ||
| $fieldStorageDefinitions['changed']->setRevisionable(TRUE); | ||
| $fieldStorageDefinitions['link']->setRevisionable(TRUE); | ||
| $fieldStorageDefinitions['langcode']->setRevisionable(TRUE); |
Contributor
There was a problem hiding this comment.
This entity is not translatable why do have a langcode field and why are we making it revisionable?
Owner
Author
There was a problem hiding this comment.
the langcode field already exists, and entity manager complains if i dont do this.
dpi
commented
May 22, 2019
| ->setInitialValueFromField('user_id'); | ||
|
|
||
|
|
||
| // Add revision created date field. |
dpi
commented
May 22, 2019
| $fields['revision_log']->setDisplayConfigurable('form', TRUE); | ||
|
|
||
|
|
||
| $fields['user_id']->setLabel(new TranslatableMarkup('Authored by')) |
dpi
commented
May 22, 2019
| */ | ||
| protected function getNewRevisionDefault() { | ||
| // Turn on revision creation by default. | ||
| return TRUE; |
dpi
commented
May 22, 2019
| * @ingroup linky | ||
| */ | ||
| interface LinkyInterface extends ContentEntityInterface, EntityChangedInterface, EntityOwnerInterface { | ||
| interface LinkyInterface extends ContentEntityInterface, EntityChangedInterface, EntityOwnerInterface, RevisionLogInterface { |
dpi
commented
May 22, 2019
| /** | ||
| * Convert linky ID column to unsigned. | ||
| */ | ||
| function linky_update_8101() { |
# Conflicts: # src/Entity/Linky.php
Contributor
|
LOL, I just commented on the issue. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WIP wip wip wip wip WIP https://www.drupal.org/project/linky/issues/3052102