Conversation
…or queue and tests dont pass but w/e
dpi
force-pushed
the
process-eventsubscriber
branch
2 times, most recently
from
8a2d7a8 to
502e7ad
Compare
dpi
force-pushed
the
process-eventsubscriber
branch
from
502e7ad to
b80538a
Compare
Removed missing newline in services yml Fixed assumptions that queue method is a reference, changed to use new queue return value. Fixed not unsetting correct value in ensureGateways Fixed redefining recipients all variable in ensureGateways Fixed ensureGateways assuming messages are entities, will now correctly clone plain messages. Fixed incorrect variable referenced in defaultsmsprovider::send Added more tests for queue return value. Added recipients to some test messages since that is now required. Tests no messages created if no recipients.
Fixed return doc for queue.
added typehinting in queue()
src/Event/RecipientGatewayEvent.php
Outdated
| * @return \Drupal\sms\Entity\SmsGatewayInterface[] | ||
| */ | ||
| public function getGatewaysSorted() { | ||
| uasort($this->gateways, function($a, $b) { |
There was a problem hiding this comment.
We shouldn't actually sort $this->gateways since the method name assumes that the original should be left unsorted.
Owner
Author
There was a problem hiding this comment.
Oh right its a reference... Can do
There was a problem hiding this comment.
Looked at sms_rule_based#1. That looks good (once I can confirm I'm okay with the event approach).
dpi
force-pushed
the
process-eventsubscriber
branch
from
98da6c0 to
76bc9ba
Compare
src/Event/RecipientGatewayEvent.php
Outdated
| }); | ||
|
|
||
| $gateways = []; | ||
| foreach ($this->gateways as $tuple) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue: Implement a more intelligent SMS Gateway selection mechanism for SMS Framework