Split verification functions into its own service.#58
Closed
dpi wants to merge 5 commits into
Closed
Conversation
fixing covers, separated verification tests to new test class
almaudoh
reviewed
Sep 19, 2016
almaudoh
left a comment
almaudoh
left a comment
There was a problem hiding this comment.
Just a quick cursory check, since this is mostly refactoring. The idea of separating phone number verification out to a service makes sense.
| $this->configFactory = $config_factory; | ||
| // Temporarily inject service until an event is created. | ||
| // See: https://www.drupal.org/node/2797121 | ||
| $this->phoneNumberVerification = $phone_number_verification; |
There was a problem hiding this comment.
Will this not be a BC-breaking change later?
Owner
Author
There was a problem hiding this comment.
So long as no-one overrides the service It'll be fine. I anticipate this will be removed soon, as soon as the discussed event in 2797121 is implemented.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/node/2797121