Issue #2677664: Added configurable phone number verification path#9
Closed
Issue #2677664: Added configurable phone number verification path#9
Conversation
Added new page config. Refactored SmsSettingsForm Sms settings form no longer redirects. Added Drupal message on setttings submission.
src/Form/SmsSettingsForm.php
Outdated
| protected $requestContext; | ||
|
|
||
| /** | ||
| * Constructs a SiteInformationForm object. |
reverted comment removal in routing.yml Fixed docblock for smssettingsform Added extra cache assertion
| ] | ||
| )); | ||
| } | ||
|
|
There was a problem hiding this comment.
Is it safe to fail silently in the case the $path_verify is malformed?
Owner
Author
There was a problem hiding this comment.
its a just-in-case, such as if there was a problem with installing module config (happens sometimes if install fails midway), or a config import/export problem.
Owner
Author
|
hmm these random test failures are interesting |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://www.drupal.org/node/2677664