Skip to content

Add ProducerBatch.__lt__ for heapq #2698

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 21, 2025
Merged

Add ProducerBatch.__lt__ for heapq #2698

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
efd8cf6
Add test
dpkp Nov 21, 2025
485953e
Add ProducerBatch.__lt__ for heapq
dpkp Nov 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions kafka/producer/producer_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -180,5 +180,6 @@ def __str__(self):
return 'ProducerBatch(topic_partition=%s, record_count=%d)' % (
self.topic_partition, self.records.next_offset())



# for heapq
def __lt__(self, other):
return self.created < other.created
15 changes: 15 additions & 0 deletions test/test_producer_batch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,3 +134,18 @@ def test_complete_exceptionally_with_null_record_errors(batch):

with pytest.raises(AssertionError):
_test_complete_exceptionally(batch, record_count, top_level_exception, None)


def test_producer_batch_lt(tp, memory_records_builder):
b1 = ProducerBatch(tp, memory_records_builder, now=1)
b2 = ProducerBatch(tp, memory_records_builder, now=2)

assert b1 < b2
assert not b1 < b1

import heapq
q = []
heapq.heappush(q, b2)
heapq.heappush(q, b1)
assert q[0] == b1
assert q[1] == b2
Loading