Add ssl_password to default_config dicts. Send ssl_password when loading cert chains #750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Thanks! |
ssaamm
added a commit
to ssaamm/kafka-python
that referenced
this pull request
Jul 25, 2016
PR dpkp#750 added the code for passing along a password, but not any documentation on it
ssaamm
added a commit
to ssaamm/kafka-python
that referenced
this pull request
Jul 25, 2016
PR dpkp#750 added the code for passing along a password, but not any documentation on it
dpkp
pushed a commit
that referenced
this pull request
Jul 26, 2016
PR #750 added the code for passing along a password, but not any documentation on it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our team wanted to be able to set an ssl_password in config so a KafkaConsumer could be created with SSL certification and not need to enter a password manually. This minor changes add the ssl_password in all the default config dicts necessary and allow for it to be set when instantiating a consumer instance.