Skip to content

SENTRY_AUTH_TOKEN passthrough to run action.#11

Merged
mdellabitta merged 1 commit intomainfrom
fix-sentry-sourcemaps
Dec 31, 2024
Merged

SENTRY_AUTH_TOKEN passthrough to run action.#11
mdellabitta merged 1 commit intomainfrom
fix-sentry-sourcemaps

Conversation

@mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Dec 31, 2024

Important

Add SENTRY_AUTH_TOKEN environment variable to GitHub Actions workflow for Sentry sourcemap upload.

  • Environment Variables:
    • Added SENTRY_AUTH_TOKEN to the Upload sourcemap to Sentry step in .github/workflows/ecr.yml to enable authentication when uploading sourcemaps.

This description was created by Ellipsis for f3f138b. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to f3f138b in 6 seconds

More details
  • Looked at 13 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. .github/workflows/ecr.yml:44
  • Draft comment:
    Ensure that SENTRY_AUTH_TOKEN is securely stored in GitHub Secrets and has the necessary permissions for the Sentry operations being performed.
  • Reason this comment was not posted:
    Confidence changes required: 50%
    The addition of the SENTRY_AUTH_TOKEN environment variable is correctly placed under the 'Upload sourcemap to Sentry' step. However, it's important to ensure that the token is securely stored and accessed.

Workflow ID: wflow_0hmfpCwaWahRNhpg


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@sonarqubecloud
Copy link

@mdellabitta mdellabitta merged commit f1989ff into main Dec 31, 2024
5 checks passed
@mdellabitta mdellabitta deleted the fix-sentry-sourcemaps branch December 31, 2024 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant