Skip to content

Added support for sentry environment config via env var.#14

Merged
mdellabitta merged 1 commit intomainfrom
add-sentry-environments
Jan 1, 2025
Merged

Added support for sentry environment config via env var.#14
mdellabitta merged 1 commit intomainfrom
add-sentry-environments

Conversation

@mdellabitta
Copy link
Contributor

@mdellabitta mdellabitta commented Dec 31, 2024

Important

Add support for configuring Sentry environment via SENTRY_ENVIRONMENT env var in instrumentation.ts.

  • Behavior:
    • Adds support for configuring Sentry environment via SENTRY_ENVIRONMENT env var in instrumentation.ts.
    • Defaults to "development" if SENTRY_ENVIRONMENT is not set.

This description was created by Ellipsis for 3ad73b7. It will automatically update as commits are pushed.

Copy link

@ellipsis-dev ellipsis-dev bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Looks good to me! Reviewed everything up to 3ad73b7 in 7 seconds

More details
  • Looked at 12 lines of code in 1 files
  • Skipped 0 files when reviewing.
  • Skipped posting 1 drafted comments based on config settings.
1. src/instrumentation.ts:10
  • Draft comment:
    Consider verifying that the default environment value 'development' aligns with the intended use case. If 'development' is not the desired default, adjust accordingly.
  • Reason this comment was not posted:
    Confidence changes required: 33%
    The use of nullish coalescing operator (??) is appropriate here to provide a default value for the environment. However, it's important to ensure that the default value aligns with the intended use case.

Workflow ID: wflow_gypaeT3ZtpXzdjzz


You can customize Ellipsis with 👍 / 👎 feedback, review rules, user-specific overrides, quiet mode, and more.

@sonarqubecloud
Copy link

@mdellabitta mdellabitta merged commit b53cfd2 into main Jan 1, 2025
5 checks passed
@mdellabitta mdellabitta deleted the add-sentry-environments branch January 1, 2025 00:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant