Skip to content

fix: do not blank line after function type's parameters sometimes #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix: do not blank line after function type's parameters sometimes #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/generation/generate.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6847,7 +6847,7 @@ fn gen_close_paren_with_type<'a>(opts: GenCloseParenWithTypeOptions<'a>, context
items.push_condition(if_true(
"newLineIfHeaderHangingAndTypeNodeMultipleLines",
Rc::new(move |context| {
if !has_type_node {
if !has_type_node || context.writer_info.is_start_of_line() {
return Some(false);
}

Expand Down
22 changes: 22 additions & 0 deletions tests/specs/issues/issue0382.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,22 @@
~~ deno: true ~~
== should not add trailing blank line after parameters in function type ==
// this is weird code, but it's set to maintain type argument newlines
type TestingTestTesttttttt<T extends TestingTestingtestingTestingggg> =
T extends Testing ? (
...args: Test<T["parameters"]>
) => Other<
Test,
Test
>
: never;

[expect]
// this is weird code, but it's set to maintain type argument newlines
type TestingTestTesttttttt<T extends TestingTestingtestingTestingggg> =
T extends Testing ? (
...args: Test<T["parameters"]>
) => Other<
Test,
Test
>
: never;